All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Tommi Rantala <tt.rantala@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@redhat.com>,
	John Stultz <john.stultz@linaro.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: clock_nanosleep() task_struct leak
Date: Mon, 4 Feb 2013 20:32:23 +0100	[thread overview]
Message-ID: <20130204193223.GA11910@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1302011450160.11905@ionos>

On 02/01, Thomas Gleixner wrote:
>
> B1;2601;0cOn Fri, 1 Feb 2013, Tommi Rantala wrote:
>
> > Hello,
> >
> > Trinity discovered a task_struct leak with clock_nanosleep(), reproducible with:
> >
> > -----8<-----8<-----8<-----
> > #include <time.h>
> >
> > static const struct timespec req;
> >
> > int main(void) {
> >         return clock_nanosleep(CLOCK_PROCESS_CPUTIME_ID,
> >                         TIMER_ABSTIME, &req, NULL);
> > }
> > -----8<-----8<-----8<-----

posix_cpu_timer_create()->get_task_struct() I guess...

Cough. I am not sure I ever understood this code, but now it certainly
looks as if I never saw it before.

All I can say is: I'll try to take another look tomorrow :/

> Groan. That code probably has more than that leak burried inside.

Oh. yes... but if you meant something connected to this particular
"test-case" please tell us ;)

Oleg.


  reply	other threads:[~2013-02-04 19:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 13:39 clock_nanosleep() task_struct leak Tommi Rantala
2013-02-01 13:52 ` Thomas Gleixner
2013-02-04 19:32   ` Oleg Nesterov [this message]
2013-02-05 10:34     ` Stanislaw Gruszka
2013-02-05 10:55       ` Thomas Gleixner
2013-02-06 11:23         ` Stanislaw Gruszka
2013-02-06 12:01           ` Tommi Rantala
2013-02-06 15:15             ` [PATCH] posix-cpu-timers: fix nanosleep " Stanislaw Gruszka
2013-02-06 16:10               ` Oleg Nesterov
2013-02-07 12:22                 ` Stanislaw Gruszka
2013-02-07 13:24                   ` Oleg Nesterov
2013-02-07 16:04                     ` [PATCH v2] " Stanislaw Gruszka
2013-02-07 18:37                       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204193223.GA11910@redhat.com \
    --to=oleg@redhat.com \
    --cc=davej@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tt.rantala@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.