From: Gleb Natapov <gleb@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Shan, Haitao" <haitao.shan@intel.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>,
"hpa@linux.intel.com" <hpa@linux.intel.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH v2 2/2] KVM: VMX: Add Posted Interrupt supporting
Date: Tue, 5 Feb 2013 09:49:31 +0200 [thread overview]
Message-ID: <20130205074931.GA25100@redhat.com> (raw)
In-Reply-To: <20130205064501.GS23213@redhat.com>
On Tue, Feb 05, 2013 at 08:45:01AM +0200, Gleb Natapov wrote:
> > >> + /* Posted interrupt descriptor */
> > >> + struct pi_desc *pi;
> > >> +
> > > You haven't answered on my previous review why are you trying save 46
> > > bytes here.
> > Sorry. I cannot get your point. It's just a pointer and only takes 8 bytes.
> And embedded structure will take 64 bytes, so by allocating it dynamically
> you are trying to save 46 bytes for !pir case per vcpu. Just embed
> pi_desc here.
>
My calculator is broken. It is 56 bytes of course. Still small enough to
embed.
--
Gleb.
prev parent reply other threads:[~2013-02-05 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 9:05 [PATCH v2 0/2] KVM: VMX: Add Posted Interrupt supporting Yang Zhang
2013-02-04 9:05 ` [PATCH v2 1/2] KVM: VMX: enable acknowledge interupt on vmexit Yang Zhang
2013-02-04 9:05 ` [PATCH v2 2/2] KVM: VMX: Add Posted Interrupt supporting Yang Zhang
2013-02-04 12:28 ` Gleb Natapov
2013-02-05 3:13 ` Zhang, Yang Z
2013-02-05 6:45 ` Gleb Natapov
2013-02-05 7:49 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205074931.GA25100@redhat.com \
--to=gleb@redhat.com \
--cc=haitao.shan@intel.com \
--cc=hpa@linux.intel.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.