From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v4] tools: set migration constraints from cmdline Date: Tue, 5 Feb 2013 11:16:54 +0100 Message-ID: <20130205101654.GA13955@aepfle.de> References: <577b051fca174be9f7b3.1359394360@probook.site> <785c8f34e1f802106e53.1359747275@probook.site> <1359983463.7743.23.camel@zakaz.uk.xensource.com> <20130204134102.GC16090@aepfle.de> <1359985584.7743.39.camel@zakaz.uk.xensource.com> <20130204135553.GB16668@aepfle.de> <1359986349.7743.46.camel@zakaz.uk.xensource.com> <20130204184301.GA31487@aepfle.de> <1360056173.7743.81.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1360056173.7743.81.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, Feb 05, Ian Campbell wrote: > On Mon, 2013-02-04 at 18:43 +0000, Olaf Hering wrote: > > On Mon, Feb 04, Ian Campbell wrote: > > > > > It just occurred to me, instead of adding lots of individual arguments > > > perhaps packing them into a (e.g.) libxl_save_properties and adding a > > > pointer would be a nicer and more extensible (in the future) interface? > > > > Something like this (copy&paste from hg diff)? > > It's a tricky balance of what goes in the struct and what goes in the > prototype but I didn't imagine putting domid or fd into the struct, > domid because that's how other libxl APIs behave and fd because it isn't > really a property of the save/migrate as such. > > Moving flags into the struct could be optional is it complicates the > compat code too much. I sent v5 with a new libxl_domain_suspend prototype. If that direction is ok I will look how to improve the LIBXL_API_VERSION handling and how to provide a knob for DEF_MIN_REMAINING. While I do that I would like to drop the hvm parameter from xc_domain_save because there is a flag for this. Olaf