From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Stuart Yoder <b08248-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Varun Sethi <varun.sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: RFC: additional domain attributes specific to PAMU
Date: Tue, 5 Feb 2013 11:35:34 +0100 [thread overview]
Message-ID: <20130205103533.GQ25591@8bytes.org> (raw)
In-Reply-To: <CALRxmdChbSk1gLXc2pqVd0GPdM09SofyjA5L_KuvSn4SQZJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Stuart,
On Mon, Feb 04, 2013 at 09:37:20PM -0600, Stuart Yoder wrote:
> + DOMAIN_ATTR_ENABLE,
> + DOMAIN_ATTR_FSL_PAMUV1,
> Instead of advertising those constraints somehow, it seem easier just
> to advertise that this IOMMU is a PAMU v1. The attribute would be
> read only and would be a boolean-- if the attribute is present then
> it's a PAMU v1.
> [...]
> Wanted to get your thoughts on that.
Sounds reasonable. Just put PAMU into the name of the attributes to make
clear these attributes are specific to your implementation and implement
the attributes in the PAMU specific get/set_attr call-backs. This is
particularily true for DOMAIN_ATTR_ENABLE (or better
DOMAIN_ATTR_PAMU_ENABLE). We can also go with DOMAIN_ATTR_FSL_PAMUV1 for
now, but a more generic way of determining the IOMMU type might make
sense. But this can be changed later.
Regards,
Joerg
prev parent reply other threads:[~2013-02-05 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 3:37 RFC: additional domain attributes specific to PAMU Stuart Yoder
[not found] ` <CALRxmdChbSk1gLXc2pqVd0GPdM09SofyjA5L_KuvSn4SQZJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-05 10:35 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205103533.GQ25591@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=b08248-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=varun.sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.