From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board Date: Tue, 5 Feb 2013 11:27:21 -0300 Message-ID: <20130205142720.GB2481@localhost> References: <1360063473-26176-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130205123827.GG20242@lunn.ch> <20130205124833.GS14746@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Thomas Petazzoni , Andrew Lunn , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Lior Amsalem , Gregory Clement , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Florian Fainelli , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jason Cooper Return-path: Content-Disposition: inline In-Reply-To: <20130205124833.GS14746-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org T24gVHVlLCBGZWIgMDUsIDIwMTMgYXQgMDc6NDg6MzNBTSAtMDUwMCwgSmFzb24gQ29vcGVyIHdy b3RlOgo+IE1vcm5pbmctaXNoIEFuZHJldywKPiAKPiBPbiBUdWUsIEZlYiAwNSwgMjAxMyBhdCAw MTozODoyN1BNICswMTAwLCBBbmRyZXcgTHVubiB3cm90ZToKPiA+ID4gQW5kIGRvbid0IGZvcmdl dCB0byBjb21waWxlIHRoZSBTUEkgZmxhc2ggZHJpdmVyLCBDT05GSUdfTVREX00yNVA4MD15Cj4g PiAKPiA+IE1heWJlIGl0IG1ha2VzIHNlbnNlIHRvIHByb3ZpZGUgYSBwYXRjaCB0byBtdmVidV9k ZWZjb25maWcgdG8gYWRkIAo+ID4gQ09ORklHX01URF9NMjVQODA9eSA/Cj4gCj4gSSB0aG91Z2h0 IHRoaXMgYXMgd2VsbCwgdGhlbiByZWNvbnNpZGVyZWQgd2hlbiBoZSBzYWlkIHRoZXJlIHdhcyBu b3RoaW5nCj4gb24gaXQuICBTbyBpdCdzIG5vdCByZWFsbHkgbmVlZGVkIHRvIGJvb3QuICBJIGRv bid0IGhhdmUgYSBzdHJvbmcKPiBvcGluaW9uIG9uIGl0IHRob3VnaCwgc28gPXksID1tLCBvciA9 bi4KPiAKCldlbGwsIHRoZSBTUEkgZmxhc2ggbWF5IG5vdCBiZSBlbXB0eSwgaWYgdGhhdCdzIHdo YXQgeW91IG1lYW50LgpGb3IgaW5zdG5hY2UsIG15IEFybWFkYSBYUCBHUCBib2FyZCBoYXMgdGhl IGJvb3Rsb2FkZXIgb24gdGhhdCBTUEksCmFuZCBib290cyBmcm9tIHRoZXJlLiBBZnRlciBib290 aW5nLCB0aGUgU1BJIGZsYXNoIGlzIG5vIGxvbmdlciBuZWVkZWQuCgpJTUhPLCBJIGRvbid0IHRo aW5rIHdlIHNob3VsZCBpbmNsdWRlIHRoZSBvcHRpb24gQ09ORklHX01URF9NMjVQODAKYXMgaXQg aXMganVzdCBhIHBhcnRpY3VsYXIgU1BJIG1hc3RlciBkZXZpY2UgcHJlc2VudCBpbiBhIHBhcnRp Y3VsYXIgYm9hcmQuCgpPbiB0aGUgb3RoZXIgaGFuZCwgSSBkb24ndCBoYXZlIGEgc3Ryb25nIG9w aW5pb24gb24gdGhpcy4KSSd2ZSBhbHdheXMgd29uZGVyZWQgdGhlICp0cnVlKiBtZWFuaW5nIG9m IGRlZmNvbmZpZ3MsCnNvIGZlZWwgZnJlZSB0byBlbmxpZ3RoZW4gbWUgOikKCi0tIApFemVxdWll bCBHYXJjw61hLCBGcmVlIEVsZWN0cm9ucwpFbWJlZGRlZCBMaW51eCwgS2VybmVsIGFuZCBBbmRy b2lkIEVuZ2luZWVyaW5nCmh0dHA6Ly9mcmVlLWVsZWN0cm9ucy5jb20KCi0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQpGcmVlIE5leHQtR2VuIEZpcmV3YWxsIEhhcmR3YXJlIE9mZmVyCkJ1eSB5b3VyIFNv cGhvcyBuZXh0LWdlbiBmaXJld2FsbCBiZWZvcmUgdGhlIGVuZCBNYXJjaCAyMDEzIAphbmQgZ2V0 IHRoZSBoYXJkd2FyZSBmb3IgZnJlZSEgTGVhcm4gbW9yZS4KaHR0cDovL3Auc2YubmV0L3NmdS9z b3Bob3MtZDJkLWZlYgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpzcGktZGV2ZWwtZ2VuZXJhbCBtYWlsaW5nIGxpc3QKc3BpLWRldmVsLWdlbmVyYWxAbGlz dHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xp c3RpbmZvL3NwaS1kZXZlbC1nZW5lcmFsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 5 Feb 2013 11:27:21 -0300 Subject: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board In-Reply-To: <20130205124833.GS14746@titan.lakedaemon.net> References: <1360063473-26176-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130205123827.GG20242@lunn.ch> <20130205124833.GS14746@titan.lakedaemon.net> Message-ID: <20130205142720.GB2481@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 05, 2013 at 07:48:33AM -0500, Jason Cooper wrote: > Morning-ish Andrew, > > On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y > > > > Maybe it makes sense to provide a patch to mvebu_defconfig to add > > CONFIG_MTD_M25P80=y ? > > I thought this as well, then reconsidered when he said there was nothing > on it. So it's not really needed to boot. I don't have a strong > opinion on it though, so =y, =m, or =n. > Well, the SPI flash may not be empty, if that's what you meant. For instnace, my Armada XP GP board has the bootloader on that SPI, and boots from there. After booting, the SPI flash is no longer needed. IMHO, I don't think we should include the option CONFIG_MTD_M25P80 as it is just a particular SPI master device present in a particular board. On the other hand, I don't have a strong opinion on this. I've always wondered the *true* meaning of defconfigs, so feel free to enligthen me :) -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com