All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] SUNRPC: Refactor nfsd4_do_encode_secinfo()
Date: Thu, 7 Feb 2013 12:14:00 -0500	[thread overview]
Message-ID: <20130207171400.GO3222@fieldses.org> (raw)
In-Reply-To: <A98AFAD6-2E43-4646-8287-8C023DFA65DF@oracle.com>

On Thu, Feb 07, 2013 at 12:12:24PM -0500, Chuck Lever wrote:
> 
> On Feb 7, 2013, at 12:03 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
> > I've thought a little about that.  There is already a logged warning if a gssd upcall times out.  But it's hard to tell inside the kernel why a module doesn't load.  These all look pretty much the same to the RPC layer:
> > 
> >   -  module is blacklisted or not installed?
> >   -  GSS support wasn't built?
> >   -  filesystem corruption?
> >   -  export specifies a security flavor the RPC client doesn't recognize?
> > 
> > I suppose I could add something here, but I wonder about the false alarms.
> 
> How about this:
> 
>   "Warning: export specifies a security flavor that isn't supported"

Sounds fine.  With a guard so we just say it once.

Bonus if we could say which export or which flavor?

--b.

      reply	other threads:[~2013-02-07 17:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 22:43 [PATCH] SUNRPC: Refactor nfsd4_do_encode_secinfo() Chuck Lever
2013-02-07 15:02 ` J. Bruce Fields
2013-02-07 15:58   ` Chuck Lever
2013-02-07 16:23     ` J. Bruce Fields
2013-02-07 16:26       ` Chuck Lever
2013-02-07 16:55         ` J. Bruce Fields
2013-02-07 17:03           ` Chuck Lever
2013-02-07 17:12             ` Chuck Lever
2013-02-07 17:14               ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130207171400.GO3222@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.