All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netfilter-devel@vger.kernel.org, jm@dilly.me, fw@strlen.de,
	Ulrich Weber <ulrich.weber@gmail.com>
Subject: Re: [RFC PATCH 1/4] netfilter: ip6t_NPT: Fix checksuming.
Date: Thu, 7 Feb 2013 19:14:11 +0100	[thread overview]
Message-ID: <20130207181411.GB18181@localhost> (raw)
In-Reply-To: <5104227C.3030306@linux-ipv6.org>

On Sun, Jan 27, 2013 at 03:37:48AM +0900, YOSHIFUJI Hideaki wrote:
> Cast __wsum from/to __sum16 is wrong.  Instead, apply appropriate
> conversion function: csum_unfold() or csum_fold().

Applied.

I have mangled this patch by collapsing Ulrich's:

http://patchwork.ozlabs.org/patch/216563/

And I have added this to the description:

    [ The original patch has been modified to undo the final ~ that
      csum_fold returns. We only need to fold the 32-bit word that
      results from the checksum calculation into a 16-bit to ensure
      that the original subnet is restored appropriately. Spotted by
      Ulrich Weber. ]

Thanks.

      parent reply	other threads:[~2013-02-07 18:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26 18:37 [RFC PATCH 1/4] netfilter: ip6t_NPT: Fix checksuming YOSHIFUJI Hideaki
2013-01-29 14:42 ` Ulrich Weber
2013-01-31 10:04   ` Pablo Neira Ayuso
2013-01-31 15:59     ` Ulrich Weber
2013-01-31 18:45       ` Jean-Michel DILLY
2013-02-03 22:31       ` Jean-Michel DILLY
2013-02-07 18:14 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130207181411.GB18181@localhost \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=jm@dilly.me \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=ulrich.weber@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.