From: Samuel Ortiz <sameo@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 08/11] mei: nfc: Initial nfc implementation
Date: Thu, 7 Feb 2013 23:41:19 +0100 [thread overview]
Message-ID: <20130207224119.GC5072@sortiz-mobl> (raw)
In-Reply-To: <201302072226.42375.arnd@arndb.de>
Hi Arnd,
On Thu, Feb 07, 2013 at 10:26:42PM +0000, Arnd Bergmann wrote:
> On Thursday 07 February 2013, Tomas Winkler wrote:
> >
> > From: Samuel Ortiz <sameo@linux.intel.com>
> >
> > NFC ME client is exported through mei bus to be consumed by the
> > NFC subsystem.
> >
> > NFC is represented by two mei clients: An info one and the actual
> > NFC one. In order for correct connection we first need to retrieve the
> > firmware information from the info client.
> >
> > Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Shouldn't this be moved to the drivers/nfc directory? Generally speaking,
> all drivers nowadays tend to live in the directories of the subsystems
> they are implementing support for, not the subsystems that they are
> implemented with.
This is a bit on the edge: This part of the MEI bus code doesn't implement
support for any NFC chipset in particular but for the MEI specific commands to
send and receive NFC HCI payloads.
So the drivers under driver/nfc call into the MEI bus I/O API which then call
this code to encapsulate the HCI payload into MEI (HECI) commands. The
microread driver in my nfc-next git.kernel.org tree uses the MEI bus API for
example.
Moreover this code actually talks to the ME at init time to understand which
exact NFC chipset is living behind the ME and add the correct device string to
the bus. So it really needs to access the MEI internal API to do so.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-02-07 22:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 21:03 [char-misc-next 00/11] Add MEI BUS and NFC Device Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation Tomas Winkler
2013-02-07 22:29 ` Arnd Bergmann
2013-02-07 22:41 ` Arnd Bergmann
2013-02-07 22:59 ` Samuel Ortiz
2013-02-07 23:07 ` Winkler, Tomas
2013-02-07 21:03 ` [char-misc-next 02/11] mei: bus: Implement driver registration Tomas Winkler
2013-02-07 22:30 ` Arnd Bergmann
2013-02-07 21:03 ` [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines Tomas Winkler
2013-02-07 22:34 ` Arnd Bergmann
2013-02-07 22:55 ` Samuel Ortiz
2013-02-11 11:52 ` Arnd Bergmann
2013-02-11 12:58 ` Samuel Ortiz
2013-02-11 15:08 ` Arnd Bergmann
2013-02-11 15:48 ` Samuel Ortiz
2013-02-11 16:12 ` Arnd Bergmann
2013-02-07 21:03 ` [char-misc-next 04/11] mei: bus: Add bus related structures to mei_cl Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 05/11] mei: bus: Call bus routines from the core code Tomas Winkler
2013-02-07 22:37 ` Arnd Bergmann
2013-02-07 22:57 ` Winkler, Tomas
2013-02-07 23:09 ` Arnd Bergmann
2013-02-07 22:57 ` Samuel Ortiz
2013-02-07 21:03 ` [char-misc-next 06/11] mei: bus: Synchronous API for the data transmission Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter Tomas Winkler
2013-02-07 22:38 ` Arnd Bergmann
2013-02-07 22:58 ` Samuel Ortiz
2013-02-07 23:57 ` Samuel Ortiz
2013-02-11 14:58 ` Arnd Bergmann
2013-02-11 15:29 ` Samuel Ortiz
2013-02-11 16:03 ` Greg KH
2013-02-11 16:05 ` Samuel Ortiz
2013-02-07 21:03 ` [char-misc-next 08/11] mei: nfc: Initial nfc implementation Tomas Winkler
2013-02-07 22:26 ` Arnd Bergmann
2013-02-07 22:41 ` Samuel Ortiz [this message]
2013-02-07 21:03 ` [char-misc-next 09/11] mei: nfc: Connect also the regular ME client Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 10/11] mei: nfc: Add NFC device to the MEI bus Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 11/11] mei: nfc: Implement MEI bus IO ops Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207224119.GC5072@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.