From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: [ 12/16] USB: EHCI: fix bug in scheduling periodic split transfers
Date: Thu, 7 Feb 2013 16:58:11 -0800 [thread overview]
Message-ID: <20130208004629.261587402@linuxfoundation.org> (raw)
In-Reply-To: <20130208004627.112511141@linuxfoundation.org>
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alan Stern <stern@rowland.harvard.edu>
commit 3e619d04159be54b3daa0b7036b0ce9e067f4b5d upstream.
This patch (as1654) fixes a very old bug in ehci-hcd, connected with
scheduling of periodic split transfers. The calculations for
full/low-speed bus usage are all carried out after the correction for
bit-stuffing has been applied, but the values in the max_tt_usecs
array assume it hasn't been. The array should allow for allocation of
up to 90% of the bus capacity, which is 900 us, not 780 us.
The symptom caused by this bug is that any isochronous transfer to a
full-speed device with a maxpacket size larger than about 980 bytes is
always rejected with a -ENOSPC error.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/host/ehci-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -236,7 +236,7 @@ static inline unsigned char tt_start_ufr
}
static const unsigned char
-max_tt_usecs[] = { 125, 125, 125, 125, 125, 125, 30, 0 };
+max_tt_usecs[] = { 125, 125, 125, 125, 125, 125, 125, 25 };
/* carryover low/fullspeed bandwidth that crosses uframe boundries */
static inline void carryover_tt_bandwidth(unsigned short tt_usecs[8])
next prev parent reply other threads:[~2013-02-08 1:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 0:57 [ 00/16] 3.0.63-stable review Greg Kroah-Hartman
2013-02-08 0:58 ` [ 01/16] drm/radeon/evergreen+: wait for the MC to settle after MC blackout Greg Kroah-Hartman
2013-02-08 0:58 ` [ 02/16] drm/radeon: add quirk for RV100 board Greg Kroah-Hartman
2013-02-08 0:58 ` [ 03/16] drm/radeon: Calling object_unrefer() when creating fb failure Greg Kroah-Hartman
2013-02-08 0:58 ` [ 04/16] x86-64: Replace left over sti/cli in ia32 audit exit code Greg Kroah-Hartman
2013-02-08 0:58 ` [ 05/16] nilfs2: fix fix very long mount time issue Greg Kroah-Hartman
2013-02-08 0:58 ` [ 06/16] drivers/rtc/rtc-isl1208.c: call rtc_update_irq() from the alarm irq handler Greg Kroah-Hartman
2013-02-08 0:58 ` [ 07/16] USB: ftdi_sio: add Zolix FTDI PID Greg Kroah-Hartman
2013-02-08 0:58 ` [ 08/16] USB: ftdi_sio: add PID/VID entries for ELV WS 300 PC II Greg Kroah-Hartman
2013-02-08 0:58 ` [ 09/16] USB: option: add support for Telit LE920 Greg Kroah-Hartman
2013-02-08 0:58 ` [ 10/16] USB: option: add Changhong CH690 Greg Kroah-Hartman
2013-02-08 0:58 ` [ 11/16] USB: qcserial: add Telit Gobi QDL device Greg Kroah-Hartman
2013-02-08 0:58 ` Greg Kroah-Hartman [this message]
2013-02-08 0:58 ` [ 13/16] USB: storage: Define a new macro for USB storage match rules Greg Kroah-Hartman
2013-02-08 0:58 ` [ 14/16] USB: storage: optimize to match the Huawei USB storage devices and support new switch command Greg Kroah-Hartman
2013-02-08 0:58 ` [ 15/16] xhci: Fix isoc TD encoding Greg Kroah-Hartman
2013-02-08 0:58 ` [ 16/16] USB: XHCI: fix memory leak of URB-private data Greg Kroah-Hartman
2013-02-08 20:28 ` [ 00/16] 3.0.63-stable review Shuah Khan
2013-02-09 12:09 ` Satoru Takeuchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208004629.261587402@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.