From: Matt Kraai <kraai@ftbfs.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Max Horn <max@quendi.de>,
Junio C Hamano <gitster@pobox.com>,
Matt Kraai <matt.kraai@amo.abbott.com>
Subject: Re: [PATCH] Use __VA_ARGS__ for all of error's arguments
Date: Thu, 7 Feb 2013 20:39:16 -0800 [thread overview]
Message-ID: <20130208043915.GB4525@ftbfs.org> (raw)
In-Reply-To: <20130208042428.GA4157@sigill.intra.peff.net>
On Thu, Feb 07, 2013 at 11:24:28PM -0500, Jeff King wrote:
> Should you be dropping most of the comment like this? I would expect it
> to be more like:
>
> We have to restrict this trick to gcc, though, because we do not
> assume all compilers support variadic macros. But since...
I'll submit a new patch with this change tomorrow.
> Other than that, I think it is OK. The compiler will still catch
> "error()" with no arguments and generate the appropriate diagnostic (in
> fact, it is better, because the error is now passing too few args to a
> function, not to the macro).
Great, thanks for the review.
--
Matt
next prev parent reply other threads:[~2013-02-08 4:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 20:00 [PATCH] Use __VA_ARGS__ for all of error's arguments Matt Kraai
2013-02-07 21:05 ` Junio C Hamano
2013-02-07 21:14 ` John Keeping
2013-02-07 21:24 ` Matt Kraai
2013-02-07 21:30 ` Matt Kraai
2013-02-08 4:24 ` Jeff King
2013-02-08 4:39 ` Matt Kraai [this message]
2013-02-08 15:09 ` Matt Kraai
2013-02-08 15:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208043915.GB4525@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matt.kraai@amo.abbott.com \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.