All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses
Date: Fri, 8 Feb 2013 15:21:52 +0000	[thread overview]
Message-ID: <20130208152152.GA2122@arm.com> (raw)
In-Reply-To: <1360323019-30139-1-git-send-email-r.sricharan@ti.com>

On Fri, Feb 08, 2013 at 11:30:18AM +0000, R Sricharan wrote:
> With LPAE enabled, alloc_init_section() does not map the entire
> address space for unaligned addresses.
> 
> The issue also reproduced with CMA + LPAE. CMA tries to map 16MB
> with page granularity mappings during boot. alloc_init_pte()
> is called and out of 16MB, only 2MB gets mapped and rest remains
> unaccessible.
> 
> Because of this OMAP5 boot is broken with CMA + LPAE enabled.
> Fix the issue by ensuring that the entire addresses are
> mapped.
> 
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Christoffer Dall <chris@cloudcar.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Tested-by: Christoffer Dall <chris@cloudcar.com>

The code looks fine but you need to fix the comments as per
Christoffer's suggestion. Otherwise:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

      parent reply	other threads:[~2013-02-08 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08 11:30 [PATCH V5] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses R Sricharan
2013-02-08 14:43 ` Christoffer Dall
2013-02-08 14:49   ` Santosh Shilimkar
2013-02-11  9:09     ` R Sricharan
2013-02-11  9:10   ` R Sricharan
2013-02-08 15:21 ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130208152152.GA2122@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.