From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports
Date: Fri, 8 Feb 2013 15:54:46 -0200 [thread overview]
Message-ID: <20130208155446.4e8caee4@redhat.com> (raw)
In-Reply-To: <1360340232-4670-6-git-send-email-armbru@redhat.com>
On Fri, 8 Feb 2013 17:17:11 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> qemu_opts_parse() reports the error already, and in a much more useful
> way.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> vl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index a8dc73d..73122d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3334,7 +3334,6 @@ int main(int argc, char **argv, char **envp)
> }
> opts = qemu_opts_parse(olist, optarg, 1);
> if (!opts) {
> - fprintf(stderr, "parse error: %s\n", optarg);
> exit(1);
> }
> break;
> @@ -3350,7 +3349,6 @@ int main(int argc, char **argv, char **envp)
> }
> opts = qemu_opts_parse(olist, optarg, 1);
> if (!opts) {
> - fprintf(stderr, "parse error: %s\n", optarg);
> exit(1);
> }
>
> @@ -3521,7 +3519,6 @@ int main(int argc, char **argv, char **envp)
> olist = qemu_find_opts("machine");
> opts = qemu_opts_parse(olist, optarg, 1);
> if (!opts) {
> - fprintf(stderr, "parse error: %s\n", optarg);
> exit(1);
> }
> optarg = qemu_opt_get(opts, "type");
> @@ -3755,7 +3752,6 @@ int main(int argc, char **argv, char **envp)
> }
> opts = qemu_opts_parse(olist, optarg, 0);
> if (!opts) {
> - fprintf(stderr, "parse error: %s\n", optarg);
> exit(1);
> }
> break;
next prev parent reply other threads:[~2013-02-08 17:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 16:17 [Qemu-trivial] [PATCH for-1.4 v2 0/6] Error reporting fixes Markus Armbruster
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines Markus Armbruster
2013-02-08 17:41 ` Luiz Capitulino
2013-02-08 18:56 ` Markus Armbruster
2013-02-08 19:13 ` Luiz Capitulino
2013-02-08 19:48 ` Markus Armbruster
2013-02-13 19:28 ` Luiz Capitulino
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 2/6] error: Clean up abuse of error_report() for help Markus Armbruster
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 3/6] error: Strip trailing '\n' from error string arguments (again) Markus Armbruster
2013-02-08 17:45 ` Luiz Capitulino
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently Markus Armbruster
2013-02-08 17:53 ` Luiz Capitulino
2013-02-08 18:58 ` Markus Armbruster
2013-02-08 19:16 ` Luiz Capitulino
2013-02-08 19:34 ` Markus Armbruster
2013-02-13 19:20 ` Luiz Capitulino
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports Markus Armbruster
2013-02-08 17:54 ` Luiz Capitulino [this message]
2013-02-08 16:17 ` [Qemu-trivial] [PATCH for-1.4 v2 6/6] vl: Exit unsuccessfully on option argument syntax error Markus Armbruster
2013-02-08 18:00 ` Luiz Capitulino
2013-02-08 18:30 ` Markus Armbruster
2013-02-08 18:59 ` [Qemu-trivial] [PATCH for-1.4 v2 0/6] Error reporting fixes Markus Armbruster
2013-02-08 19:16 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208155446.4e8caee4@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.