From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Fri, 08 Feb 2013 22:39:45 +0000 Subject: [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB In-Reply-To: <1357576928-29133-4-git-send-email-thomas.petazzoni@free-electrons.com> References: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com> <1357576928-29133-4-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <20130208223945.D316E3E2C27@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 7 Jan 2013 17:42:08 +0100, Thomas Petazzoni wrote: > Now that we have a 7-segment display driver in the kernel, use it on > the Marvell Armada XP DB evaluation board. > > Signed-off-by: Thomas Petazzoni > --- > arch/arm/boot/dts/armada-xp-db.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts > index 8e53b25..8654c1b 100644 > --- a/arch/arm/boot/dts/armada-xp-db.dts > +++ b/arch/arm/boot/dts/armada-xp-db.dts > @@ -90,5 +90,10 @@ > phy = <&phy3>; > phy-mode = "sgmii"; > }; > + gpio-7seg at 0 { > + compatible = "generic,gpio-7seg"; > + status = "okay"; > + gpios = <&gpio0 26 0 &gpio0 27 0 &gpio1 16 0>; > + }; Nit: The node probably belongs at the base of the tree. A direct child of the root node because it really doen't make sense as a child of anything else. It's more of a system level device. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB Date: Fri, 08 Feb 2013 22:39:45 +0000 Message-ID: <20130208223945.D316E3E2C27@localhost> References: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com> <1357576928-29133-4-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1357576928-29133-4-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Thomas Petazzoni , Arnd Bergmann , Greg Kroah-Hartman Cc: Lior Amsalem , Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 7 Jan 2013 17:42:08 +0100, Thomas Petazzoni wrote: > Now that we have a 7-segment display driver in the kernel, use it on > the Marvell Armada XP DB evaluation board. > > Signed-off-by: Thomas Petazzoni > --- > arch/arm/boot/dts/armada-xp-db.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts > index 8e53b25..8654c1b 100644 > --- a/arch/arm/boot/dts/armada-xp-db.dts > +++ b/arch/arm/boot/dts/armada-xp-db.dts > @@ -90,5 +90,10 @@ > phy = <&phy3>; > phy-mode = "sgmii"; > }; > + gpio-7seg@0 { > + compatible = "generic,gpio-7seg"; > + status = "okay"; > + gpios = <&gpio0 26 0 &gpio0 27 0 &gpio1 16 0>; > + }; Nit: The node probably belongs at the base of the tree. A direct child of the root node because it really doen't make sense as a child of anything else. It's more of a system level device. g.