From: Jean Sacren <sakiwit@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: create skb_panic() to let caller specify panic
Date: Sat, 9 Feb 2013 23:40:24 -0700 [thread overview]
Message-ID: <20130210064024.GC2496@mail.gmail.com> (raw)
In-Reply-To: <1360476173.26127.3.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Sat, 09 Feb 2013 22:02:53 -0800
>
> On Sat, 2013-02-09 at 22:56 -0700, Jean Sacren wrote:
> > From: Joe Perches <joe@perches.com>
> > > Don't split the format across multiple lines please.
> []
> > Honestly I didn't want to split the whole string, but I was in the
> > dilemma of accommodating 80-column convention. I'm ready to respin if
> > the consensus favors one long string. But how long is too long?
>
> Documentation/CodingStyle
>
> Chapter 2: Breaking long lines and strings
> ...
> never break user-visible strings such as printk messages,
> because that breaks the ability to grep for them
I appreciate you for sharing this document with me, but this scenario is
unique, as it concerns panic. Under this circumstance, are we able to
grep?
--
Jean Sacren
next prev parent reply other threads:[~2013-02-10 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 4:49 [PATCH] skbuff: create skb_panic() to let caller specify panic Jean Sacren
2013-02-10 5:11 ` Joe Perches
2013-02-10 5:56 ` Jean Sacren
2013-02-10 6:02 ` Joe Perches
2013-02-10 6:40 ` Jean Sacren [this message]
2013-02-10 6:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210064024.GC2496@mail.gmail.com \
--to=sakiwit@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.