diff for duplicates of <20130210235125.GA8098@jack.whiskey> diff --git a/a/1.txt b/N1/1.txt index 661f9f8..a9e7788 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -58,14 +58,14 @@ WARNING: Avoid CamelCase: <PPI_HSTimeoutEnable> > + r = i2c_transfer(tc358765_i2c->client->adapter, msg, ARRAY_SIZE(msg)); > + mutex_unlock(&tc358765_i2c->xfer_lock); > + -> + if (r = ARRAY_SIZE(msg)) +> + if (r == ARRAY_SIZE(msg)) > + return len; > + > + return r; If you like, here you could do - return (r = ARRAY_SIZE(msg)) ? len : r; + return (r == ARRAY_SIZE(msg)) ? len : r; Usually I like more this notation because keeps the code more compact and immediate to read, but you don't have to diff --git a/a/content_digest b/N1/content_digest index edaae96..9f2b02e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01360338220-12753-2-git-send-email-ruslan.bilovol@ti.com\0" "From\0Andi Shyti <andi@etezian.org>\0" "Subject\0Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards\0" - "Date\0Sun, 10 Feb 2013 23:51:25 +0000\0" + "Date\0Mon, 11 Feb 2013 00:51:25 +0100\0" "To\0Ruslan Bilovol <ruslan.bilovol@ti.com>\0" "Cc\0andi@etezian.org" tomi.valkeinen@ti.com @@ -72,14 +72,14 @@ "> +\tr = i2c_transfer(tc358765_i2c->client->adapter, msg, ARRAY_SIZE(msg));\n" "> +\tmutex_unlock(&tc358765_i2c->xfer_lock);\n" "> +\n" - "> +\tif (r = ARRAY_SIZE(msg))\n" + "> +\tif (r == ARRAY_SIZE(msg))\n" "> +\t\treturn len;\n" "> +\n" "> +\treturn r;\n" "\n" "If you like, here you could do\n" "\n" - "\treturn (r = ARRAY_SIZE(msg)) ? len : r;\n" + "\treturn (r == ARRAY_SIZE(msg)) ? len : r;\n" "\n" "Usually I like more this notation because keeps the code more\n" "compact and immediate to read, but you don't have to\n" @@ -239,4 +239,4 @@ "\n" Andi -aad9468f7cdb7c0ed4744fc60c765c81c0f898fd10e0536d6bc79bc3050c2ea9 +27de6627d41bdaa1f8be9210133c40597c77b53f265623a2f0f2f07789d6d23d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.