All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW
Date: Mon, 11 Feb 2013 10:11:09 +0100	[thread overview]
Message-ID: <20130211091109.GA3890@osiris> (raw)
In-Reply-To: <1360432485-25726-1-git-send-email-geert@linux-m68k.org>

On Sat, Feb 09, 2013 at 06:54:45PM +0100, Geert Uytterhoeven wrote:
> s390 allmodconfig:
> 
> drivers/gpu/drm/udl/udl_fb.c:237:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/media/pci/zoran/zoran_driver.c:2955:14: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/media/usb/cpia2/cpia2_core.c:2405:66: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/udlfb.c:337:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/smscufx.c:795:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/vfb.c:431:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> 
> According to an email from Martin a few years ago, the equivalent define
> for s390 is PAGE_RW, so make PAGE_SHARED an alias for PAGE_RW.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/s390/include/asm/pgtable.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
> index 098adbb..0ca3e62 100644
> --- a/arch/s390/include/asm/pgtable.h
> +++ b/arch/s390/include/asm/pgtable.h
> @@ -386,6 +386,7 @@ extern unsigned long MODULES_END;
> 
>  #define PAGE_KERNEL	PAGE_RW
>  #define PAGE_COPY	PAGE_RO
> +#define PAGE_SHARED	PAGE_RW

Thanks Geert. A similar patch however is already in linux-next, together
with a whole bunch of other patches which try to make s390's allmodconfig
compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI
code.

  reply	other threads:[~2013-02-11  9:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09 17:54 [PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW Geert Uytterhoeven
2013-02-11  9:11 ` Heiko Carstens [this message]
2013-02-12  9:20   ` Geert Uytterhoeven
2013-02-12  9:40     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211091109.GA3890@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.