From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org, George Pontis <GPontis@z9.com>
Subject: Re: i.MX53 - add WEIM register defines
Date: Mon, 11 Feb 2013 10:12:48 +0100 [thread overview]
Message-ID: <20130211091248.GP1906@pengutronix.de> (raw)
In-Reply-To: <1360351249.78170872@f48.mail.ru>
On Fri, Feb 08, 2013 at 11:20:49PM +0400, Alexander Shiyan wrote:
> > Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )
> >
> > Signed-off-by: George Pontis <gpontis@spamcop.net>
> >
> > diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h
> > bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
> > --- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
> > 06:24:51.000000000 -0800
> > +++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
> > 23:14:45.982747680 -0800
> > @@ -1,6 +1,17 @@
> > #ifndef __MACH_IMX53_REGS_H
> > #define __MACH_IMX53_REGS_H
> >
> > +/* WEIM registers */
> > +#define WEIM_CSxGCR1(n) (((n) * 0x18) + 0x00)
> > +#define WEIM_CSxGCR2(n) (((n) * 0x18) + 0x04)
> > +#define WEIM_CSxRCR1(n) (((n) * 0x18) + 0x08)
> > +#define WEIM_CSxRCR2(n) (((n) * 0x18) + 0x0c)
> > +#define WEIM_CSxWCR1(n) (((n) * 0x18) + 0x10)
> > +#define WEIM_CSxWCR2(n) (((n) * 0x18) + 0x14)
> > +#define WEIM_WCR 0x90
> > +#define WEIM_WIAR 0x94
> > +#define WEIM_EAR 0x98
>
> If register set is really same as i.MX51, then probably we should
> move these definitions from imx51-regs.h to imx5.h. Sascha?
Even better add a imx53_setup_weimcs() function like we have for various
other i.MXes in mach/weim.h.
(add a imx5_setup_weimcs function which has an additional base address
argument. This would then be called from
imx51_setup_weimcs/imx53_setup_weimcs).
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-11 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 19:05 i.MX53 - add WEIM register defines George Pontis
2013-02-08 19:20 ` Alexander Shiyan
2013-02-11 9:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211091248.GP1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=GPontis@z9.com \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.