From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755385Ab3BKLDU (ORCPT ); Mon, 11 Feb 2013 06:03:20 -0500 Received: from mga03.intel.com ([143.182.124.21]:54273 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754500Ab3BKLDT (ORCPT ); Mon, 11 Feb 2013 06:03:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,641,1355126400"; d="scan'208";a="255369225" Date: Mon, 11 Feb 2013 12:03:11 +0100 From: Samuel Ortiz To: Greg KH Cc: Tomas Winkler , arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [char-misc-next 02/11 V2] mei: bus: Implement driver registration Message-ID: <20130211110311.GM20996@sortiz-mobl> References: <1360326504-17041-1-git-send-email-tomas.winkler@intel.com> <1360326504-17041-3-git-send-email-tomas.winkler@intel.com> <20130208235524.GB24127@kroah.com> <20130210033218.GH20996@sortiz-mobl> <20130210163623.GB939@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130210163623.GB939@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 10, 2013 at 08:36:23AM -0800, Greg KH wrote: > On Sun, Feb 10, 2013 at 04:32:18AM +0100, Samuel Ortiz wrote: > > Hi Greg, > > > > On Fri, Feb 08, 2013 at 03:55:24PM -0800, Greg KH wrote: > > > On Fri, Feb 08, 2013 at 02:28:15PM +0200, Tomas Winkler wrote: > > > > From: Samuel Ortiz > > > > > > > > Signed-off-by: Samuel Ortiz > > > > Signed-off-by: Tomas Winkler > > > > Acked-by: Arnd Bergmann > > > > --- > > > > drivers/misc/mei/bus.c | 29 +++++++++++++++++++++++++++++ > > > > include/linux/mei_bus.h | 3 +++ > > > > 2 files changed, 32 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c > > > > index bb96423c..0a5e624 100644 > > > > --- a/drivers/misc/mei/bus.c > > > > +++ b/drivers/misc/mei/bus.c > > > > @@ -153,3 +153,32 @@ void mei_remove_device(struct mei_bus_client *client) > > > > device_unregister(&client->dev); > > > > } > > > > EXPORT_SYMBOL(mei_remove_device); > > > > + > > > > +int mei_driver_register(struct mei_bus_driver *driver) > > > > +{ > > > > + int err; > > > > + > > > > + /* Can't register until after driver model init */ > > > > + if (unlikely(WARN_ON(!mei_bus_type.p))) > > > > + return -EAGAIN; > > > > > > No, you really don't know what 'p' is, so don't assume you do. You have > > > fields you can test to see if your driver model is up and registered, > > > use them instead. > > Unless I'm missing something, I would actually need to track if the bus type > > is registered or not from bus.c. I can't find any field from bus_type that > > tells me for sure if my bus is registered or not, except for p. > > I actually think I don't need that check anyway. IIRC, this is something I > > took from i2c-core.c but in the ME case it's most likely not needed. > > It's your bus, if you need to check this, then have your own flag, don't > poke in the driver core internals. As you point out, I don't think you > need to check this at all. Yes, I removed the check. Tomas should sent v3 later today with all your comments adressed. Thanks for the review. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/