From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
Nick Piggin <npiggin@suse.de>,
Stewart Smith <stewart@flamingspork.com>
Subject: Re: RFC: mincore: add a bit to indicate a page is dirty.
Date: Mon, 11 Feb 2013 14:12:39 -0800 [thread overview]
Message-ID: <20130211141239.f4decf03.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130211162701.GB13218@cmpxchg.org>
On Mon, 11 Feb 2013 11:27:01 -0500
Johannes Weiner <hannes@cmpxchg.org> wrote:
> > Is PG_dirty the right choice? Is that right for huge pages? Should I
> > assume is_migration_entry(entry) means it's not dirty, or is there some
> > other check here?
>
> If your only consequence of finding dirty pages is to sync, would you
> be better off using fsync/fdatasync maybe?
Yes, if the data is all on disk then an fsync() will be a no-op. IOW,
if (I need to fsync)
fsync();
is equivalent to
fsync();
Methinks we need to understand the requirement better.
Also, having to mmap the file to be able to query pagecache state is a
hack. Whatever happened to the fincore() patch?
next prev parent reply other threads:[~2013-02-11 22:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 3:13 RFC: mincore: add a bit to indicate a page is dirty Rusty Russell
2013-02-11 16:27 ` Johannes Weiner
2013-02-11 22:12 ` Andrew Morton [this message]
2013-02-12 5:44 ` Rusty Russell
2013-02-15 6:34 ` [patch 1/2] mm: fincore() Johannes Weiner
2013-02-15 6:34 ` Johannes Weiner
2013-02-15 20:39 ` David Miller
2013-02-15 20:39 ` David Miller
2013-02-15 21:14 ` Andrew Morton
2013-02-15 21:14 ` Andrew Morton
2013-02-15 22:28 ` Johannes Weiner
2013-02-15 22:28 ` Johannes Weiner
2013-02-15 22:34 ` Andrew Morton
2013-02-15 22:34 ` Andrew Morton
2013-02-15 21:27 ` Andrew Morton
2013-02-15 21:27 ` Andrew Morton
2013-02-15 23:13 ` Johannes Weiner
2013-02-15 23:13 ` Johannes Weiner
2013-02-15 23:42 ` Andrew Morton
2013-02-15 23:42 ` Andrew Morton
2013-02-16 4:23 ` Rusty Russell
2013-02-16 4:23 ` Rusty Russell
2013-02-17 22:51 ` Johannes Weiner
2013-02-17 22:51 ` Johannes Weiner
2013-02-17 22:54 ` Andrew Morton
2013-02-17 22:54 ` Andrew Morton
2013-05-29 14:53 ` Andres Freund
2013-05-29 14:53 ` Andres Freund
2013-05-29 17:32 ` Johannes Weiner
2013-05-29 17:32 ` Johannes Weiner
2013-05-29 17:52 ` Andres Freund
2013-05-29 17:52 ` Andres Freund
2013-02-18 5:41 ` Rusty Russell
2013-02-18 5:41 ` Rusty Russell
2013-02-19 10:25 ` Simon Jeons
2013-02-19 10:25 ` Simon Jeons
2013-02-15 6:35 ` [patch 2/2] x86-64: hook up fincore() syscall Johannes Weiner
2013-02-15 6:35 ` Johannes Weiner
2013-02-12 5:49 ` RFC: mincore: add a bit to indicate a page is dirty Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211141239.f4decf03.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=stewart@flamingspork.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.