From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757562Ab3BKP3d (ORCPT ); Mon, 11 Feb 2013 10:29:33 -0500 Received: from mga14.intel.com ([143.182.124.37]:7313 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756758Ab3BKP3c (ORCPT ); Mon, 11 Feb 2013 10:29:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,643,1355126400"; d="scan'208";a="201105864" Date: Mon, 11 Feb 2013 16:29:29 +0100 From: Samuel Ortiz To: Arnd Bergmann Cc: Tomas Winkler , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter Message-ID: <20130211152929.GS20996@sortiz-mobl> References: <1360270997-7639-1-git-send-email-tomas.winkler@intel.com> <20130207225809.GG5072@sortiz-mobl> <20130207235724.GA14612@sortiz-mobl> <201302111458.37452.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201302111458.37452.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Mon, Feb 11, 2013 at 02:58:37PM +0000, Arnd Bergmann wrote: > On Thursday 07 February 2013, Samuel Ortiz wrote: > > > > On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: > > > On Thu, Feb 07, 2013 at 10:38:44PM +0000, Arnd Bergmann wrote: > > > > On Thursday 07 February 2013, Tomas Winkler wrote: > > > > > > > > > > +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) > > > > > +{ > > > > > + return dev_get_drvdata(&client->dev); > > > > > +} > > > > > +EXPORT_SYMBOL(mei_bus_get_clientdata); > > > > > + > > > > > > > > Did you really mean to export an inline function? > > > > > > > > Can you make this a static inline function in a header file instead? > > > Sure, will do. > > Actually, I'd like to keep the mei_bus_client structure opaque to the MEI bus > > drivers. So I'll still export those symbols without inlining them. > > Ok, makes sense. I assume when you say "bus driver" you mean what other > subsystems call a "device driver". That's correct, yes. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/