From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by arago-project.org (Postfix) with ESMTPS id E915452A20 for ; Mon, 11 Feb 2013 20:29:03 +0000 (UTC) Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r1BKT3mQ021880 for ; Mon, 11 Feb 2013 14:29:03 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id r1BKT32C015378 for ; Mon, 11 Feb 2013 14:29:03 -0600 Received: from dlelxv22.itg.ti.com (172.17.1.197) by dfle73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.1.323.3; Mon, 11 Feb 2013 14:29:02 -0600 Received: from localhost ([158.218.102.158]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r1BKT3QX028711; Mon, 11 Feb 2013 14:29:03 -0600 Date: Mon, 11 Feb 2013 15:29:02 -0500 From: Denys Dmytriyenko To: "Zhou, Jingting" Message-ID: <20130211202902.GG11440@edge> References: <3C08AEEB3C731745938BC83D029FE5E3917A77@DFLE09.ent.ti.com> <20130211200804.GB11440@edge> <3C08AEEB3C731745938BC83D029FE5E391813D@DFLE09.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <3C08AEEB3C731745938BC83D029FE5E391813D@DFLE09.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: new image recipe X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2013 20:29:04 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Feb 11, 2013 at 03:25:44PM -0500, Zhou, Jingting wrote: > 1. I'll use another name It's not the name. Why cannot you use the existing arago-headless-tisdk-image recipe? Can you extend it instead of creating another one? > 2. the white spaces are consistent in my computer...... Some lines use spaces and some use tabs, which is inconsistent - you may want to configure your text editor to show you one vs. another visually. -- Denys > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Monday, February 11, 2013 3:08 PM > To: Zhou, Jingting > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] new image recipe > > On Wed, Feb 06, 2013 at 09:18:15PM +0000, Zhou, Jingting wrote: > > Hey all, attached is the recipe for a new image > > arago-headless-tisdk-keystone2-image. Please take a look. Thanks~ > > All the comments I made to your previous patch are still applicable here, > plus: > > 1. Don't make tasks or images specific to a machine/SoC like that. First of > all, you can avoid making it completely machine-specific and second, you may > need to use overrides in the recipe itself for really specific things. > > 2. Please make sure the whitespaces are consistent.