From: Michael Ellerman <michael@ellerman.id.au>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
Date: Tue, 12 Feb 2013 13:00:39 +1100 [thread overview]
Message-ID: <20130212020039.GA8979@concordia> (raw)
In-Reply-To: <1360593750.25941.13.camel@thor.lan>
On Mon, Feb 11, 2013 at 09:42:30AM -0500, Peter Hurley wrote:
> Hi Michael,
>
> On Mon, 2013-02-11 at 13:44 +1100, Michael Ellerman wrote:
> > On Wed, Jan 30, 2013 at 01:33:57PM -0500, Peter Hurley wrote:
> > > On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote:
> > > > On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> > > > > Jiri, was there anything on the mailing list that I missed that should
> > > > > have resolved this issue? I thought it was being worked on, but I can't
> > > > > seem to find any resolution at the moment.
> > > >
> > > > Somebody had a patchset and promised to repost IIRC. I forgot his name
> > > > though.
> > > >
> > > > /me back from digging in the mail history.
> > > >
> > > > Peter Hurley is the name.
> > > >
> > > > Peter, what happened with your patches in the end, please?
> > >
> > > The tty subsystem is very resilient to fixing :)
> > >
> > > The thing I'm working on right now -- which hopefully is the last issue
> > > with the line discipline logic -- occurs with parallel __tty_hangup()
> > > and tty_release().
> > >
> > > At the moment, I'm trying to narrow the conditions when this happens.
> >
> > If it helps I seem to be able to reproduce this in just a few seconds by
> ^^^^^^^^^^^^^^
> you get this WARNING from a parallel __tty_hangup?
>
> Or do you mean simply that you get this WARNING?
Sorry I just mean I'm seeing the warning, I have no idea how.
> > running trinity and hitting Ctrl-C to quit the watchdog.
>
> Can you reproduce after using the following patch series?
> [PATCH v3 00/23] ldisc fixes
What are they against? I tried Linus' tree and linux-next but they
didn't apply cleanly against either.
cheers
next prev parent reply other threads:[~2013-02-12 2:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 15:37 WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL) Dave Jones
2013-01-18 20:53 ` Dave Jones
2013-01-18 21:07 ` Greg Kroah-Hartman
2013-01-19 21:00 ` Jiri Slaby
2013-01-30 18:33 ` Peter Hurley
2013-02-11 2:44 ` Michael Ellerman
2013-02-11 14:42 ` Peter Hurley
2013-02-12 2:00 ` Michael Ellerman [this message]
2013-02-12 2:53 ` Peter Hurley
2013-02-12 6:41 ` Michael Ellerman
2013-02-12 11:34 ` Peter Hurley
2013-02-17 6:26 ` Shawn Guo
2013-02-17 6:26 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212020039.GA8979@concordia \
--to=michael@ellerman.id.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.