Re: [PATCH] virtio_console: Let unconnected rproc device receive data.

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Feb 12, 2013 at 10:14:59AM +0100, Sjur Brændeland wrote:
> Hi Amit,
> 
> > > @@ -1763,8 +1763,11 @@ static void in_intr(struct virtqueue *vq)
> >
> > > >      * tty is spawned) and the host sends out data to console
> > > >      * ports.  For generic serial ports, the host won't
> > > >      * (shouldn't) send data till the guest is connected.
> > > > +    * However a remote device might send data before the port is
> > > > +    * connected. So don't remove data from a rproc_serial device.
> > > >      */
> > > > -   if (!port->guest_connected)
> > > > +
> > > > +   if (!port->guest_connected && !is_rproc_serial(port->portdev-
> > > >vdev))
> > > >             discard_port_data(port);
> > >
> > > How about setting port->guest_connected = true in the init routines
> > > instead?  Keeps this code path cleaner.
> >
> > Agree, I'll respin this patch.
> 
> Hm, Rusty has already picked this up.

I don't see it in virtio-next. Do you?

> Do you still want me to do a respin,
> or should I leave it as is?
> 
> Regards,
> Sjur