From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] checksum: remove duplicated line of code in csum_fold
Date: Tue, 12 Feb 2013 18:41:44 +0100 [thread overview]
Message-ID: <20130212174143.GA24888@localhost> (raw)
In-Reply-To: <20130212.121235.1398926681356889354.davem@davemloft.net>
On Tue, Feb 12, 2013 at 12:12:35PM -0500, David Miller wrote:
> From: pablo@netfilter.org
> Date: Tue, 12 Feb 2013 18:10:03 +0100
>
> > From: Pablo Neira Ayuso <pablo@netfilter.org>
> >
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> I am very sure that those two lines are there intentionally.
> The first addition one can overflow, therefore we need to
> fold again (which cannot overflow).
I was missing that, make sense indeed, thanks.
prev parent reply other threads:[~2013-02-12 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 17:10 [PATCH] checksum: remove duplicated line of code in csum_fold pablo
2013-02-12 17:12 ` David Miller
2013-02-12 17:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212174143.GA24888@localhost \
--to=pablo@netfilter.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.