From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 1/1] netfilter: ctnetlink: don't permit ct creation with random tuple
Date: Tue, 12 Feb 2013 23:35:49 +0100 [thread overview]
Message-ID: <20130212223549.GA7045@localhost> (raw)
In-Reply-To: <1360660958-29494-1-git-send-email-fw@strlen.de>
On Tue, Feb 12, 2013 at 10:22:38AM +0100, Florian Westphal wrote:
> Userspace can cause kernel panic by not specifying orig/reply
> tuple: kernel will create a tuple with random stack values.
>
> Problem is that tuple.dst.dir will be random, too, which
> causes nf_ct_tuplehash_to_ctrack() to return garbage.
Applied, thanks Florian.
prev parent reply other threads:[~2013-02-12 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 9:22 [PATCH 1/1] netfilter: ctnetlink: don't permit ct creation with random tuple Florian Westphal
2013-02-12 12:24 ` Pablo Neira Ayuso
2013-02-12 12:43 ` Florian Westphal
2013-02-12 13:10 ` Pablo Neira Ayuso
2013-02-12 22:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212223549.GA7045@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.