From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/6] drm/i915: Don't wait for page flips if
 there was GPU reset
Date: Wed, 13 Feb 2013 12:51:33 +0200
Message-ID: <20130213105133.GN9135@intel.com>
References: <1359476018-31274-1-git-send-email-ville.syrjala@linux.intel.com>
	<1359476018-31274-3-git-send-email-ville.syrjala@linux.intel.com>
	<20130213102328.GB20865@dyon.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id B7C79E6605
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 13 Feb 2013 02:51:36 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130213102328.GB20865@dyon.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Feb 13, 2013 at 10:23:28AM +0000, Damien Lespiau wrote:
> On Tue, Jan 29, 2013 at 06:13:34PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > If a GPU reset occurs while a page flip has been submitted to the ring,
> > the flip will never complete once the ring has been reset.
> > =

> > The GPU reset can be detected by sampling the reset_counter before the
> > flip is submitted, and then while waiting for the flip, the sampled
> > counter is compared with the current reset_counter value.
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> =

> You might want to rename reset_counter to flip_reset_counter to indicate
> this field is specific to the flipping code. Other parts of the code
> might need something similar as well?

IIRC I used flip_reset_counter initially but then I decided it's too
long and dropped the flip_ part. I can change it back if that's what
people prefer.

-- =

Ville Syrj=E4l=E4
Intel OTC