From: Matt Kraai <kraai@ftbfs.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Matt Kraai <matt.kraai@amo.abbott.com>
Subject: Re: [PATCH] Makefile: don't run rm without any files
Date: Wed, 13 Feb 2013 09:00:28 -0800 [thread overview]
Message-ID: <20130213170028.GA410@ftbfs.org> (raw)
In-Reply-To: <7vtxpg9mxq.fsf@alter.siamese.dyndns.org>
On Wed, Feb 13, 2013 at 08:51:45AM -0800, Junio C Hamano wrote:
> Matt Kraai <kraai@ftbfs.org> writes:
>
> > From: Matt Kraai <matt.kraai@amo.abbott.com>
> >
> > "rm -f -r" fails on QNX when not passed any files to remove.
>
> I do not think it is limited to QNX.
>
> > the clean target, since dep_dirs is empty.
>
> And dep_dirs being empty under some circumstance shouldn't be
> limited to QNX, either.
>
> I think your change does no harm, may be a good change if dep_dirs
> goes empty, but the justification is lacking. What caused your
> dep_dirs to become empty in the first place?
>
> I am scratching my head because I see
>
> OBJECTS := $(LIB_OBJS) $(BUILTIN_OBJS) $(PROGRAM_OBJS) $(TEST_OBJS) \
> $(XDIFF_OBJS) \
> $(VCSSVN_OBJS) \
> git.o
> dep_dirs := $(addsuffix .depend,$(sort $(dir $(OBJECTS))))
I don't set COMPUTE_HEADER_DEPENDENCIES, so it defaults to "auto".
The automatic detection determines that the compiler doesn't support
it, so it's then set to "no". CHECK_HEADER_DEPENDENCIES isn't set
either, so about 20 lines below the dep_dirs assignment you quoted,
dep_dirs is cleared:
ifneq ($(COMPUTE_HEADER_DEPENDENCIES),yes)
ifndef CHECK_HEADER_DEPENDENCIES
dep_dirs =
...
Should I submit an updated patch with a different commit message?
next prev parent reply other threads:[~2013-02-13 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:57 [PATCH] Makefile: don't run rm without any files Matt Kraai
2013-02-13 16:51 ` Junio C Hamano
2013-02-13 17:00 ` Matt Kraai [this message]
2013-02-13 20:01 ` Junio C Hamano
2013-02-13 20:12 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213170028.GA410@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=matt.kraai@amo.abbott.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.