From: Greg KH <gregkh@linuxfoundation.org>
To: George Spelvin <linux@horizon.com>
Cc: giometti@linux.it, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, peter@hurleysoftware.com
Subject: Re: [PATCH v2 8/9] pps: Use a single cdev
Date: Wed, 13 Feb 2013 10:47:00 -0800 [thread overview]
Message-ID: <20130213184700.GA15633@kroah.com> (raw)
In-Reply-To: <20130213183529.27043.qmail@science.horizon.com>
On Wed, Feb 13, 2013 at 01:35:29PM -0500, George Spelvin wrote:
> > You forgot a Signed-off-by: line for this patch, so I can't apply it, or
> > the 9/9 patch :(
>
> Oops, fixed. I don't see why the 9/9 patch depends on it,
> though. They're not related or interdependent in any way.
>
> If you want to check the logic, I'd appreciate it. I'm not
> really sure about the RCU stuff. My understanding is that:
> - the idr code does the appropriate write locking when
> modifying itself, so I don't need to do any.
> - The pps_device returned from idr_find is itself refcounted,
> so it can't go away, and the accesses don't have bo be
> inside the RCU read "lock". It's only the IDR's internal
> index nodes that might get reallocated by modificaitons of
> a different part of the tree.
>
> > Care to resend just these two after fixing this up?
>
> I can, but if you think you need 9/9 resent (which *did* have a S-o-b),
> I'm confused and wonder why...
I stopped at that point in the series, that's the only reason why, I
didn't "check" to see if there was a dependancy, I just assumed there
was...
So please resend, thanks.
greg k-h
next prev parent reply other threads:[~2013-02-13 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 13:56 [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731 George Spelvin
2013-02-06 15:55 ` [PATCH v2 7/9] tty: Remove ancient hardpps() Peter Hurley
2013-02-08 6:50 ` [PATCH v2 9/9] tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close George Spelvin
2013-02-10 9:08 ` [PATCH v2 1/9] pps: Add pps_lookup_dev() function George Spelvin
2013-02-10 9:41 ` [PATCH v2 2/9] pps: Use pps_lookup_dev to reduce ldisc coupling George Spelvin
2013-02-10 9:43 ` [PATCH v2 4/9] pps: Don't crash the machine when exiting will do George Spelvin
2013-02-10 9:44 ` [PATCH v2 6/9] pps: Additional cleanups in uart_handle_dcd_change George Spelvin
2013-02-12 7:00 ` [PATCH v2 5/9] pps: Move timestamp read into PPS code proper George Spelvin
2013-02-13 18:16 ` Greg KH
2013-02-12 7:02 ` [PATCH v2 8/9] pps: Use a single cdev George Spelvin
2013-02-13 18:20 ` Greg KH
2013-02-13 18:35 ` George Spelvin
2013-02-13 18:47 ` Greg KH [this message]
2013-02-21 1:35 ` Peter Hurley
2013-02-12 7:27 ` [PATCH v2 3/9] pps: Fix a use-after free bug when unregistering a source George Spelvin
2013-02-13 16:45 ` [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731 Greg KH
2013-02-13 17:11 ` Rodolfo Giometti
2013-02-13 17:11 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213184700.GA15633@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=giometti@linux.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@horizon.com \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.