From: Borislav Petkov <bp@alien8.de>
To: Scan Subscription <scan-subscription@coverity.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: New Defect(s) reported by Coverity Scan
Date: Wed, 13 Feb 2013 20:13:52 +0100 [thread overview]
Message-ID: <20130213191352.GC18013@pd.tnic> (raw)
In-Reply-To: <C0A4ACBB26D853488EA0C68388B70268172CD159@BLUPRD0512MB628.namprd05.prod.outlook.com>
On Wed, Feb 13, 2013 at 06:55:03PM +0000, Scan Subscription wrote:
> Hi Boris
>
> There is no fclose(file) call in parse_zoffset() function
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob_plain;f=arch/x86/boot/tools/build.c;hb=HEAD
>
> There is only one flcose call in this file and it is in the main() function
> Let us know if I am missing anything
Right, I was staring at older sources, sorry.
This parse_zoffset() thing has come in just recently with
commit 99f857db8857aff691c51302f93648263ed07eb1
Author: David Woodhouse <David.Woodhouse@intel.com>
Date: Thu Jan 10 14:31:59 2013 +0000
x86, build: Dynamically find entry points in compressed startup code
and it might really need fclose() there for correctness' sake.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-13 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 17:40 New Defect(s) reported by Coverity Scan Scan Subscription
2013-02-13 18:38 ` Borislav Petkov
2013-02-13 18:55 ` Scan Subscription
2013-02-13 19:13 ` Borislav Petkov [this message]
2013-02-13 23:15 ` H. Peter Anvin
2013-02-13 23:22 ` Borislav Petkov
2013-02-13 23:24 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2013-04-05 15:32 Scan Subscription
2013-04-01 22:34 Scan Subscription
2013-04-01 22:53 ` David Miller
2013-04-08 18:33 ` Steven Rostedt
2013-01-29 20:00 Scan Subscription
2013-01-01 0:13 Scan Subscription
2012-08-22 22:00 Scan Subscription
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213191352.GC18013@pd.tnic \
--to=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scan-subscription@coverity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.