All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Sacren <sakiwit@gmail.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic()
Date: Wed, 13 Feb 2013 12:43:07 -0700	[thread overview]
Message-ID: <20130213194307.GE13159@mail.gmail.com> (raw)
In-Reply-To: <1360754427-9051-1-git-send-email-james.hogan@imgtec.com>

From: James Hogan <james.hogan@imgtec.com>
Date: Wed, 13 Feb 2013 11:20:27 +0000
>
> I get the following build error on next-20130213 due to the following
> commit:
> 
> commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create
> skb_panic() function and its wrappers").
> 
> It adds an argument called panic to a function that uses the BUG() macro
> which tries to call panic, but the argument masks the panic() function
> declaration, resulting in the following error (gcc 4.2.4):
> 
> net/core/skbuff.c In function 'skb_panic':
> net/core/skbuff.c +126 : error: called object 'panic' is not a function
> 
> This is fixed by renaming the argument to msg.
> 
> Signed-off-by: James Hogan <james.hogan@imgtec.com>

Thanks, James.

I'm sorry I introduced this bug. Shame on me.

-- 
Jean Sacren

      parent reply	other threads:[~2013-02-13 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 11:20 [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic() James Hogan
2013-02-13 11:20 ` James Hogan
2013-02-13 12:41 ` Sedat Dilek
2013-02-13 16:52   ` David Miller
2013-02-13 19:43 ` Jean Sacren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213194307.GE13159@mail.gmail.com \
    --to=sakiwit@gmail.com \
    --cc=davem@davemloft.net \
    --cc=james.hogan@imgtec.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.