All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Rob Herring <robherring2@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] dma: of-dma.c: fix memory leakage
Date: Thu, 14 Feb 2013 11:16:10 +0100	[thread overview]
Message-ID: <20130214101610.GA29017@gmail.com> (raw)
In-Reply-To: <20130212174025.GB17659@intel.com>

The memory allocated to ofdma might be a leakage when error occurs.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/dma/of-dma.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index 59631b2..583e50e3 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
 	if (!nbcells) {
 		pr_err("%s: #dma-cells property is missing or invalid\n",
 		       __func__);
+		kfree(ofdma);
 		return -EINVAL;
 	}
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-02-14 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19 13:06 [PATCH] of: dma.c: fix memory leakage Cong Ding
2013-01-20 22:24 ` Rob Herring
2013-01-22 10:10   ` Cong Ding
2013-02-12 17:40     ` Vinod Koul
2013-02-13 11:26       ` Cong Ding
2013-02-14  4:42         ` Vinod Koul
2013-02-14 10:16       ` Cong Ding [this message]
     [not found]         ` <20130214101610.GA29017-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-14 13:42           ` [PATCH v2] dma: of-dma.c: " Vinod Koul
2013-02-14 13:42             ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214101610.GA29017@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robherring2@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.