From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regmap: debugfs: Add a registers `range' file
Date: Thu, 14 Feb 2013 14:43:06 +0000 [thread overview]
Message-ID: <20130214144305.GP13249@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1360845104-30392-1-git-send-email-dp@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Thu, Feb 14, 2013 at 12:31:44PM +0000, Dimitris Papastamos wrote:
> @@ -96,6 +116,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
> if (c) {
> c->max = p - 1;
> c->max_reg = i - 1;
> + c->reg_attr = regmap_attr_bitmap(map, c->max_reg);
> list_add_tail(&c->list,
> &map->debugfs_off_cache);
> c = NULL;
What happens if we have three registers like below?
X: read, write
X+1: read, write, volatile
X+2: read, write
It looks like we'll not flag X+1 as volatile, we'll just take the last
value we saw.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-14 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 12:31 [PATCH 1/2] regmap: debugfs: Add a registers `range' file Dimitris Papastamos
2013-02-14 14:43 ` Mark Brown [this message]
2013-02-14 15:00 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214144305.GP13249@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.