All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe MacDonald <Joe.MacDonald@windriver.com>
To: Aws Ismail <aws.ismail@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH 1/3] traceroute: resolve multilib issues
Date: Thu, 14 Feb 2013 11:42:30 -0500	[thread overview]
Message-ID: <20130214164229.GF3156@windriver.com> (raw)
In-Reply-To: <511D1213.4080905@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2573 bytes --]

[Re: [meta-networking][PATCH  1/3] traceroute: resolve multilib issues] On 13.02.14 (Thu 11:34) Aws Ismail wrote:

> On 02/13/2013 10:34 PM, Joe MacDonald wrote:
> >[[meta-networking][PATCH  1/3] traceroute: resolve multilib issues] On 13.02.11 (Mon 13:16) Aws Ismail wrote:
> >
> >>Make recipe changes to enable successfull building
> >>when multilib is being used.
> >>
> >>Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
> >>---
> >>  .../traceroute/traceroute_2.0.18.bb                |    8 +++++---
> >>  1 files changed, 5 insertions(+), 3 deletions(-)
> >>
> >>diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> >>index 6eca731..f5f96b2 100644
> >>--- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> >>+++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> >>@@ -11,6 +11,8 @@ LICENSE = "GPL-2.0 LGPL-2.1"
> >>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
> >>                      file://COPYING.LIB;md5=bbb461211a33b134d42ed5ee802b37ff"
> >>+PR = "r1"
> >>+
> >>  inherit update-alternatives
> >>  SRC_URI = "${SOURCEFORGE_MIRROR}/traceroute/traceroute/traceroute-2.0.18/traceroute-2.0.18.tar.gz \
> >>@@ -26,13 +28,13 @@ do_compile() {
> >>  do_install() {
> >>      install -d ${D}${bindir}
> >>-    install -m755 ${PN}/${PN} ${D}${bindir}
> >>+    install -m755 ${BPN}/${BPN} ${D}${bindir}
> >>      install -m755 wrappers/tcptraceroute ${D}${bindir}
> >>      install -d ${D}${mandir}
> >>-    install -p -m644 ${PN}/${PN}.8 ${D}${mandir}
> >>-    ln -s ${PN}.8 ${D}${mandir}/${PN}6.8
> >>+    install -p -m644 ${BPN}/${BPN}.8 ${D}${mandir}
> >>+    ln -s ${PN}.8 ${D}${mandir}/${BPN}6.8
> >>      ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8
> >Are the targets actually installed as ${PN}.8 and not ${BPN}.8 in a
> >multilib build scenario?  What I'm asking is should the above be changed
> >to this instead:
> >
> >     ln -s ${BPN}.8 ${D}${mandir}/${BPN}6.8
> >     ln -s ${BPN}.8 ${D}${mandir}/tcptraceroute.8
> >
> I think you're right. It should be like that but the odd
> thing is that even with ln -s ${PN}.8 no errors were
> seen.

Weird.  But okay.

So, so long as the BPN version is doing the right thing -- meaning it's
actually creating a proper link and not a broken link, because ln is
pretty happy to do whatever you tell it even if it doesn't make sense --
can you send out a revised patch set?

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-02-14 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 18:16 [meta-networking][PATCH 0/3] multilib fixes for some networking recipes Aws Ismail
2013-02-11 18:16 ` [meta-networking][PATCH 1/3] traceroute: resolve multilib issues Aws Ismail
2013-02-14  3:34   ` Joe MacDonald
2013-02-14 16:34     ` Aws Ismail
2013-02-14 16:42       ` Joe MacDonald [this message]
2013-02-11 18:16 ` [meta-networking][PATCH 2/3] netcat-openbsd: " Aws Ismail
2013-02-11 18:16 ` [meta-networking][PATCH 3/3] accel-ppp: resolve QA warnings and satisfy multilib Aws Ismail
  -- strict thread matches above, loose matches on Subject: below --
2013-02-14 20:39 [meta-networking][PATCH 0/3][V2] multilib fixes for some networking recipes Aws Ismail
2013-02-14 20:39 ` [meta-networking][PATCH 1/3] traceroute: resolve multilib issues Aws Ismail

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214164229.GF3156@windriver.com \
    --to=joe.macdonald@windriver.com \
    --cc=aws.ismail@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.