From: Ben Widawsky <ben@bwidawsk.net>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add \n to the end of sysfs attributes
Date: Thu, 14 Feb 2013 09:46:36 -0800 [thread overview]
Message-ID: <20130214174635.GA20674@bwidawsk.net> (raw)
In-Reply-To: <1360831331-30040-1-git-send-email-jani.nikula@intel.com>
On Thu, Feb 14, 2013 at 10:42:11AM +0200, Jani Nikula wrote:
> It is customary to end sysfs attributes with a newline.
>
As best I can tell, you are correct. Have you tested powertop with this
change? If not, can you?
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-02-14 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 8:42 [PATCH] drm/i915: add \n to the end of sysfs attributes Jani Nikula
2013-02-14 17:46 ` Ben Widawsky [this message]
2013-02-19 10:33 ` Jani Nikula
2013-02-19 11:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214174635.GA20674@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.