All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: "Lukáš Czerner" <lczerner@redhat.com>,
	"Christoph Hellwig" <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
Date: Thu, 14 Feb 2013 13:19:52 -0600	[thread overview]
Message-ID: <20130214191952.GG22182@sgi.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1302121635070.2315@(none)>

Hey Lukas,

On Tue, Feb 12, 2013 at 04:37:37PM +0100, Lukáš Czerner wrote:
> On Tue, 12 Feb 2013, Eric Sandeen wrote:
> 
> > Date: Tue, 12 Feb 2013 09:11:38 -0600
> > From: Eric Sandeen <sandeen@sandeen.net>
> > To: Lukas Czerner <lczerner@redhat.com>
> > Cc: xfs@oss.sgi.com
> > Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
> > 
> > On 2/12/13 5:59 AM, Lukas Czerner wrote:
> > > When '-N' is specified we really should not write anything to the
> > > device, neither we should attempt to discard the device.
> > > 
> > > This commit fixes xfs_mkfs to not attempt to discard the device in the
> > > case user specified '-N' flag.
> > 
> > Thanks, and yes - ouch, this shouldn't happen with -N, that's bad!
> > 
> > But it doesn't look like this is against the current git tree,
> > it applies only with a lot of fuzz & offsets.
> 
> Ah, I've been using 
> 
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> 
> and I can remember that it's not the first time I've realized that I
> am using wrong repo. Obviously i am not paying a lot of attention to
> the xfs channel, but does this keep changing, or is it just me ? :)

It changed just twice, AFAIK.

Christoph, could you clean up the kernel.org trees to help resolve the
confusion?

> Will resend the patch based on the
> 
> git://oss.sgi.com/xfs/cmds/xfsprogs.git

This is the right place, thanks.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-02-14 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 11:59 [PATCH] xfs_mkfs: Do not discard if '-N' is provided Lukas Czerner
2013-02-12 15:11 ` Eric Sandeen
2013-02-12 15:37   ` Lukáš Czerner
2013-02-14 19:19     ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214191952.GG22182@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=lczerner@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.