From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 03/10] drm/i915: clear the
 FPGA_DBG_RM_NOCLAIM bit at driver init
Date: Thu, 14 Feb 2013 20:07:04 -0800
Message-ID: <20130214200704.00005d3b@unknown>
References: <1360352121-3989-1-git-send-email-przanoni@gmail.com>
	<1360352121-3989-4-git-send-email-przanoni@gmail.com>
	<20130209091906.000054de@unknown>
	<CA+gsUGREveN6PzXAFG7-hOiOaW4NF1HTRdp7hvW1JvEkMcpxBA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id A37BEE5EC8
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 14 Feb 2013 20:07:22 -0800 (PST)
In-Reply-To: <CA+gsUGREveN6PzXAFG7-hOiOaW4NF1HTRdp7hvW1JvEkMcpxBA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 14 Feb 2013 18:26:59 -0200
Paulo Zanoni <przanoni@gmail.com> wrote:

> Hi
> 
> 2013/2/9 Ben Widawsky <ben@bwidawsk.net>:
> > On Fri,  8 Feb 2013 17:35:14 -0200
> > Paulo Zanoni <przanoni@gmail.com> wrote:
> >
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> Otherwise, if the BIOS did anything wrong, our first
> >> I915_{WRITE,READ} will give us "unclaimed register"  messages.
> >>
> >> V2: Even earlier.
> >>
> >> Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58897
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > I really wish we were allowed to call Haswell something like
> > gen7.x, so we can do INTEL_INFO(dev)->gen > 7
> 
> Like gen 70 and 75?

Yeah, but that's not your problem or fault.
> 
> >
> > Also, I would have cleared all the bits in the register, not just
> > NOCLAIM.
> 
> I'm not so sure, the other bits have completely different purposes,
> unrelated with the "unclaimed registers". I don't think it's a good
> idea to zero bits that have nothing to do with the purpose of the
> code.

I think doing that is a separate patch, and it goes along with the
"we don't care what errors BIOS induced" philosophy IMO.

> 
> >
> > Either way it's
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Thanks for the review :)
> 
> > [snip]
> 
> 
>