From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/xc: print messages from xc_save with
 xc_report
Date: Fri, 15 Feb 2013 21:36:41 +0100
Message-ID: <20130215203641.GA15504@aepfle.de>
References: <83a05c99299d60197fbb.1360958844@probook.site>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <83a05c99299d60197fbb.1360958844@probook.site>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 15, Olaf Hering wrote:

> +++ b/tools/xcutils/xc_save.c

>      si.xce = xc_evtchn_open(NULL, 0);
>      if (si.xce == NULL)
> -        warnx("failed to open event channel handle");
> +        WPRINTF("failed to open event channel handle");
>      else
>      {
>          port = xs_suspend_evtchn_port(si.domid);
>  
>          if (port < 0)
> -            warnx("failed to get the suspend evtchn port\n");
> +            WPRINTF("failed to get the suspend evtchn port\n");
>          else
>          {
>              si.suspend_evtchn =
>                xc_suspend_evtchn_init(si.xch, si.xce, si.domid, port);
>  
>              if (si.suspend_evtchn < 0)
> -                warnx("suspend event channel initialization failed, "
> +                WPRINTF("suspend event channel initialization failed, "
>                         "using slow path");
>          }

Is this path well tested, or should these three be fatal errors?

Olaf