Re: [PATCH 17/18] tisdk-image: Add support for new toolchain sdk structure

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Feb 11, 2013 at 06:46:18PM -0600, fcooperjr27@gmail.com wrote:
> From: Franklin S. Cooper Jr <fcooper@ti.com>
> 
> * Previous the toolchain sdk was delivered as a simple tar.gz file that
>   could be extracted.
> * Now the toolchain sdk needs to be installed via a self contained script
>   installer that provides alot more flexibility.
> * Need to tweak this class to reflect this change.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
>  meta-arago-distro/classes/tisdk-image.bbclass |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-arago-distro/classes/tisdk-image.bbclass b/meta-arago-distro/classes/tisdk-image.bbclass
> index c2f93e2..b08f93b 100644
> --- a/meta-arago-distro/classes/tisdk-image.bbclass
> +++ b/meta-arago-distro/classes/tisdk-image.bbclass
> @@ -478,6 +478,11 @@ do_sdk_image () {
>  
>  	mkdir -p ${IMAGE_ROOTFS}/etc
>  
> +    chmod 755 ${DEPLOY_DIR}/sdk/${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-tisdk-${SDK_ARCH}*
> +
> +    # Temporarily extract the toolchain sdk so we can read license information from it.
> +    echo "${IMAGE_ROOTFS}/${TISDK_TOOLCHAIN_PATH}" | ${DEPLOY_DIR}/sdk/${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-tisdk-${SDK_ARCH}*

Why not use -y and -d path?

${DEPLOY_DIR}/sdk/${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-tisdk-${SDK_ARCH}* -y -d "${IMAGE_ROOTFS}/${TISDK_TOOLCHAIN_PATH}"


>      # Creat the base SDK image
>  	rootfs_${IMAGE_PKGTYPE}_do_rootfs
>  
> @@ -562,6 +567,14 @@ do_sdk_image () {
>      # Create the TI software manifest
>      generate_sw_manifest
>  
> +    # Delete installed toolchain sdk since we need the toolchain sdk installer
> +    # not the extracted version
> +    rm -rf ${IMAGE_ROOTFS}/${TISDK_TOOLCHAIN_PATH}
> +
> +    # Copy over the toolchain sdk installer an give it a simple name which
> +    # matches the traditional name within the SDK.
> +    cp ${DEPLOY_DIR}/sdk/${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-tisdk-${SDK_ARCH}* ${IMAGE_ROOTFS}/linux-devkit.sh
> +
>      # Copy the opkg.conf used by the image to allow for future updates
>      cp ${WORKDIR}/opkg.conf ${IMAGE_ROOTFS}/etc/
>  
> @@ -574,6 +587,11 @@ do_sdk_image () {
>      ${@get_imagecmds(d)}
>  }
>  
> +license_create_manifest() {
> +    # Override license_create_manifest and do nothing
> +    echo ""

Usually you'd use colon ":" for noop command:

blah() {
	:
}


> +}
> +
>  EXPORT_FUNCTIONS do_sdk_image
>  addtask sdk_image before do_build after do_install
>  
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago