All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Pravin B Shelar <pshelar@nicira.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: [PATCH net-next] ip: fix warning in xfrm4_mode_tunnel_input
Date: Sat, 16 Feb 2013 09:40:29 -0800	[thread overview]
Message-ID: <20130216094029.4d2fc993@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130216093815.45e2d8b2@nehalam.linuxnetplumber.net>

Same problem as IPv6

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/net/ipv4/xfrm4_mode_tunnel.c	2013-02-16 09:09:41.388937316 -0800
+++ b/net/ipv4/xfrm4_mode_tunnel.c	2013-02-16 09:39:21.849910500 -0800
@@ -142,7 +142,8 @@ static int xfrm4_mode_tunnel_input(struc
 	for_each_input_rcu(rcv_notify_handlers, handler)
 		handler->handler(skb);
 
-	if (err = skb_unclone(skb, GFP_ATOMIC))
+	err = skb_unclone(skb, GFP_ATOMIC);
+	if (err)
 		goto out;
 
 	if (x->props.flags & XFRM_STATE_DECAP_DSCP)

  reply	other threads:[~2013-02-16 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 17:38 [PATCH net-next] ipv6: fix warning in xfrm6_mode_tunnel_input Stephen Hemminger
2013-02-16 17:40 ` Stephen Hemminger [this message]
2013-02-18 17:43   ` [PATCH net-next] ip: fix warning in xfrm4_mode_tunnel_input David Miller
2013-02-18 17:43 ` [PATCH net-next] ipv6: fix warning in xfrm6_mode_tunnel_input David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130216094029.4d2fc993@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.