From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 16 Feb 2013 10:07:39 +0000 Subject: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding In-Reply-To: References: <1360952512-971558-1-git-send-email-arnd@arndb.de> <1360952512-971558-3-git-send-email-arnd@arndb.de> Message-ID: <201302161007.39657.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 16 February 2013, Viresh Kumar wrote: > On 15 February 2013 23:51, Arnd Bergmann wrote: > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documentation/devicetree/bindings/dma/snps-dma.txt > > +- #dma-cells: must be <3> > > > +DMA clients connected to the Designware DMA controller must use the format > > +described in the dma.txt file, using a five-cell specifier for each channel. > > s/five/four ? Right. I thought I had fixed up all instances. > > +static bool dw_dma_generic_filter(struct dma_chan *chan, void *param) > > { > > > + dws->cfg_hi = 0xffffffff; > > + dws->cfg_lo = 0xffffffff; > > s/0xffffffff/-1 ? It's an 'unsigned int'. While -1 would work here, I always find it a little odd to rely on that feature of the C language. Thannks for the review. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding Date: Sat, 16 Feb 2013 10:07:39 +0000 Message-ID: <201302161007.39657.arnd@arndb.de> References: <1360952512-971558-1-git-send-email-arnd@arndb.de> <1360952512-971558-3-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: Vinod Koul , Vinod Koul , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , Andy Shevchenko , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Saturday 16 February 2013, Viresh Kumar wrote: > On 15 February 2013 23:51, Arnd Bergmann wrote: > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documentation/devicetree/bindings/dma/snps-dma.txt > > +- #dma-cells: must be <3> > > > +DMA clients connected to the Designware DMA controller must use the format > > +described in the dma.txt file, using a five-cell specifier for each channel. > > s/five/four ? Right. I thought I had fixed up all instances. > > +static bool dw_dma_generic_filter(struct dma_chan *chan, void *param) > > { > > > + dws->cfg_hi = 0xffffffff; > > + dws->cfg_lo = 0xffffffff; > > s/0xffffffff/-1 ? It's an 'unsigned int'. While -1 would work here, I always find it a little odd to rely on that feature of the C language. Thannks for the review. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976Ab3BPKIA (ORCPT ); Sat, 16 Feb 2013 05:08:00 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:64331 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752660Ab3BPKH6 (ORCPT ); Sat, 16 Feb 2013 05:07:58 -0500 From: Arnd Bergmann To: Viresh Kumar Subject: Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding Date: Sat, 16 Feb 2013 10:07:39 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-6-generic; KDE/4.3.2; x86_64; ; ) Cc: Vinod Koul , Dan Williams , linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Olof Johansson , linux-kernel@vger.kernel.org, Andy Shevchenko , Vinod Koul References: <1360952512-971558-1-git-send-email-arnd@arndb.de> <1360952512-971558-3-git-send-email-arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201302161007.39657.arnd@arndb.de> X-Provags-ID: V02:K0:MxYObTeRuNjM+b7P+iU5f3iq2D6H4ia1G4tneNNPAmO ILO6CrPUKYx8NsGGA2wUA4PFyia8VYfpCJCgBj3letC+djUeaM 78J32g8OLRbZSxKseIFsZjGiKExCMPI8YsnVWyeposcIvz9WSA B0KEQEmre1y89eZgJxbl9IXSwP+rtFY0fJFrOxeMg4kNNekW16 MezLOZMR6AmiD9i1M3AxfZIwuC0hKAEM1id3pC0MpXcP1XBFD2 Lexeb4SSjREHkZSsg55xVMVX8HEy/IqpnbcF/uuvCLITXgaE/m ZatQecw6ufvV1CVzl5JmvkhOBGepYt+PF+G1JM6mmMIE1cdUTa F+mIKODNtZK7Vv9/+0+I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 16 February 2013, Viresh Kumar wrote: > On 15 February 2013 23:51, Arnd Bergmann wrote: > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documentation/devicetree/bindings/dma/snps-dma.txt > > +- #dma-cells: must be <3> > > > +DMA clients connected to the Designware DMA controller must use the format > > +described in the dma.txt file, using a five-cell specifier for each channel. > > s/five/four ? Right. I thought I had fixed up all instances. > > +static bool dw_dma_generic_filter(struct dma_chan *chan, void *param) > > { > > > + dws->cfg_hi = 0xffffffff; > > + dws->cfg_lo = 0xffffffff; > > s/0xffffffff/-1 ? It's an 'unsigned int'. While -1 would work here, I always find it a little odd to rely on that feature of the C language. Thannks for the review. Arnd