From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Ingo Molnar <mingo@redhat.com>,
Mandeep Singh Baines <msb@chromium.org>,
Neil Horman <nhorman@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Roland McGrath <roland@hack.frob.com>, Tejun Heo <tj@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] coredump: fix the ancient signal problems
Date: Sun, 17 Feb 2013 21:01:03 +0100 [thread overview]
Message-ID: <20130217200103.GC22544@redhat.com> (raw)
In-Reply-To: <20130217195044.GA22544@redhat.com>
On 02/17, Oleg Nesterov wrote:
>
> On 02/17, Linus Torvalds wrote:
> >
> > SIGKILL really is very very special. Having it kill a
> > coredump in progress sounds fine to me.
>
> Great.
Forgot to mention just in case...
We could probably make a simpler patch. do_coredump() can ignore
all signals except SIGKILL from the start. But when I suggested
this change in the past I was told that the dump handler looks
(or may look) at /proc/pid/status so we shouldn't do this.
And instead of s/SIGNAL_GROUP_EXIT/group_exit_task/ in 2/3 we
could add the ugly but simple checks in __send_signal() paths.
Say we could rely on PF_DUMPCORE (which btw asks for cleanup
anyway).
However, I think that using ->group_exit_task is better (if
correct!) and simply more logical.
Oleg.
next prev parent reply other threads:[~2013-02-17 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 19:18 [PATCH 0/3] coredump: fix the ancient signal problems Oleg Nesterov
2013-02-17 19:18 ` [PATCH 1/3] coredump: only SIGKILL should interrupt the coredumping task Oleg Nesterov
2013-02-17 19:19 ` [PATCH 2/3] coredump: ensure that SIGKILL always kills the dumping thread Oleg Nesterov
2013-02-17 19:19 ` [PATCH 3/3] coredump: sanitize the setting of signal->group_exit_code Oleg Nesterov
2013-02-17 19:34 ` [PATCH 0/3] coredump: fix the ancient signal problems Linus Torvalds
2013-02-17 19:50 ` Oleg Nesterov
2013-02-17 20:01 ` Oleg Nesterov [this message]
2013-02-20 1:29 ` Mandeep Singh Baines
2013-02-20 22:32 ` Oleg Nesterov
2013-02-20 23:14 ` Andrew Morton
2013-02-23 20:21 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130217200103.GC22544@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msb@chromium.org \
--cc=nhorman@redhat.com \
--cc=rjw@sisk.pl \
--cc=roland@hack.frob.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.