From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: Bluetooth Linux <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 12/12] Bluetooth: Remove empty HCI event handlers
Date: Mon, 18 Feb 2013 09:51:46 +0200 [thread overview]
Message-ID: <20130218075146.GD17232@x220> (raw)
In-Reply-To: <CAMXE1-pn2V-6mgvqpwDygaqgsUr90yV7BS_txyzGQytA4gTABw@mail.gmail.com>
Hi Andrei,
On Sun, Feb 17, 2013, Andrei Emeltchenko wrote:
> > With the removal of hci_req_complete() several HCI event handles have
> > essentially become empty and can be removed.
>
> It is still good to have debug traces.
If you need to trace exactly what HCI events are happening btmon and
hcidump are probably much more useful tools for that than kernel debug
logs. And even if you do want debug logs we can just add single BT_DBT()
calls to the hci_cmd_complete() and hci_cmd_status() functions instead
of creating a new function for every single event just for the sake of
having a debug log for them.
Johan
prev parent reply other threads:[~2013-02-18 7:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 14:50 [PATCH 00/12] Bluetooth: Asynchronous HCI transaction API Johan Hedberg
2013-02-13 14:50 ` [PATCH 01/12] Bluetooth: Add initial hooks for HCI transaction support Johan Hedberg
2013-02-13 14:50 ` [PATCH 02/12] Bluetooth: Add basic start/complete HCI transaction functions Johan Hedberg
2013-02-14 17:48 ` Andre Guedes
2013-02-15 8:22 ` Johan Hedberg
2013-02-15 8:36 ` Szymon Janc
2013-02-15 9:06 ` Johan Hedberg
2013-02-15 9:18 ` Szymon Janc
2013-02-15 9:52 ` Johan Hedberg
2013-02-13 14:50 ` [PATCH 03/12] Bluetooth: Add hci_transaction_cmd_complete function Johan Hedberg
2013-02-14 17:48 ` Andre Guedes
2013-02-13 14:50 ` [PATCH 04/12] Bluetooth: Add hci_transaction_from_skb function Johan Hedberg
2013-02-13 14:50 ` [PATCH 05/12] Bluetooth: Switch from hdev->cmd_q to using transactions Johan Hedberg
2013-02-13 14:50 ` [PATCH 06/12] Bluetooth: Remove unused hdev->cmd_q HCI command queue Johan Hedberg
2013-02-13 14:50 ` [PATCH 07/12] Bluetooth: Fix mgmt powered indication by using a HCI transaction Johan Hedberg
2013-02-13 14:50 ` [PATCH 08/12] Bluetooth: Enable HCI transaction support cmd_status 0 Johan Hedberg
2013-02-14 17:48 ` Andre Guedes
2013-02-13 14:50 ` [PATCH 09/12] Bluetooth: Add HCI init sequence support for HCI transactions Johan Hedberg
2013-02-13 17:10 ` Anderson Lizardo
2013-02-15 8:17 ` Johan Hedberg
2013-02-13 14:50 ` [PATCH 10/12] Bluetooth: Convert hci_request to use " Johan Hedberg
2013-02-13 14:50 ` [PATCH 11/12] Bluetooth: Remove unused hdev->init_last_cmd Johan Hedberg
2013-02-13 14:50 ` [PATCH 12/12] Bluetooth: Remove empty HCI event handlers Johan Hedberg
[not found] ` <CAMXE1-pn2V-6mgvqpwDygaqgsUr90yV7BS_txyzGQytA4gTABw@mail.gmail.com>
2013-02-18 7:51 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218075146.GD17232@x220 \
--to=johan.hedberg@gmail.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.