From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] Add Generic GPIO driver
Date: Mon, 18 Feb 2013 11:06:42 +0100 [thread overview]
Message-ID: <20130218100642.GO1906@pengutronix.de> (raw)
In-Reply-To: <1360954167-18993-1-git-send-email-shc_work@mail.ru>
Hi Alexander,
On Fri, Feb 15, 2013 at 10:49:27PM +0400, Alexander Shiyan wrote:
> This patch adds generic memory-mapped GPIO controller support.
> Code taken from Linux Kernel and adopted for barebox.
I'm fine with this if you add a user for it. I wonder though if it's
worth it to have this driver for barebox. If I have a driver in the
kernel that already uses it, then this makes it simple to copy it, but
should I have to write a new gpio driver, I'm unsure if it's simpler
to write a new gpio driver or to register with the generic gpio
driver.
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 89be684..565f5bd 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -6,10 +6,20 @@ if GPIOLIB
>
> menu "GPIO"
>
> +config GPIO_GENERIC
> + def_bool y
> +
Please do not unconditionally enable this for all configs.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-18 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 18:49 [RFC] Add Generic GPIO driver Alexander Shiyan
2013-02-18 10:06 ` Sascha Hauer [this message]
2013-02-18 10:13 ` Re[2]: " Alexander Shiyan
2013-02-18 10:19 ` Sascha Hauer
2013-02-19 7:09 ` Re[2]: " Alexander Shiyan
2013-02-19 7:26 ` Sascha Hauer
2013-02-19 7:34 ` Re[2]: " Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218100642.GO1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.