From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>,
devel@driverdev.osuosl.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] staging/xgifb: Remove duplicated code in loops.
Date: Mon, 18 Feb 2013 14:18:24 +0300 [thread overview]
Message-ID: <20130218111824.GE6802@mwanda> (raw)
In-Reply-To: <1360957033-11876-5-git-send-email-peterhuewe@gmx.de>
On Fri, Feb 15, 2013 at 08:37:13PM +0100, Peter Huewe wrote:
> - for (i = 0; i < 256; i++) {
> - outb((unsigned char) DAC_TEST_PARMS[0], (pVBInfo->P3c8 + 1));
> - outb((unsigned char) DAC_TEST_PARMS[1], (pVBInfo->P3c8 + 1));
> - outb((unsigned char) DAC_TEST_PARMS[2], (pVBInfo->P3c8 + 1));
> + for (i = 0; i < 256 * 3; i++) {
> + outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
The original code looks buggy, but it's been that way from the
initial commit so I have no idea what was intended. Perhaps the
"+ 1" was supposed to be a "+ i". There is no way to know really.
regards,
dan carpenter
prev parent reply other threads:[~2013-02-18 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 19:37 [PATCH 1/5] staging/xgifb: Consolidate if/else if with identical code branches Peter Huewe
2013-02-15 19:37 ` [PATCH 2/5] staging/xgifb: Remove unnecessary casts Peter Huewe
2013-02-15 19:37 ` [PATCH 3/5] staging/xgifb: Remove code without effect Peter Huewe
2013-02-18 11:25 ` Dan Carpenter
2013-02-15 19:37 ` [PATCH 4/5] staging/xgifb: Consolidate return paths Peter Huewe
2013-02-15 19:37 ` [PATCH 5/5] staging/xgifb: Remove duplicated code in loops Peter Huewe
2013-02-18 11:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218111824.GE6802@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.