From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Layton <jlayton@redhat.com>
Cc: NeilBrown <neilb@suse.de>,
"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
NFS <linux-nfs@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: More fun with unmounting ESTALE directories.
Date: Mon, 18 Feb 2013 20:15:02 +0000 [thread overview]
Message-ID: <20130218201502.GH4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130218144655.42b3f3e3@tlielax.poochiereds.net>
On Mon, Feb 18, 2013 at 02:46:55PM -0500, Jeff Layton wrote:
> Ok, that helps. In that case, this patch might be a reasonable
> forward-port of the one Neil sent earlier today. Note that this doesn't
> really do anything for the umount problem, but it does seem to fix the
> testcase for the problem I've been looking at.
>
> Thoughts?
If we really go for "in this case revalidate should be weaker", we might
as well introduce a separate method for it.
As it is, we have several callers of ->d_revalidate(); this one (in
complete_walk(), only for FS_REVAL_DOT filesystems) and ones in
lookup_dcache() and lookup_fast() (in both cases we have and want the
name to match). There are only two fs with FS_REVAL_DOT present - nfs
and 9p. *IF* we want to make ->d_revalidate() on NFS behave differently
in complete_walk() case, it would argue for just splitting the method
in two, replacing FS_REVAL_DOT with "dentry has this method" and probably
taking a good look at what 9p needs in the same case.
next prev parent reply other threads:[~2013-02-18 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 0:38 More fun with unmounting ESTALE directories NeilBrown
2013-02-14 15:42 ` Jeff Layton
2013-02-18 2:25 ` NeilBrown
2013-02-18 12:41 ` Jeff Layton
2013-02-18 15:36 ` Chuck Lever
2013-02-18 21:58 ` J. Bruce Fields
2013-02-18 22:05 ` Jeff Layton
2013-02-18 22:16 ` Chuck Lever
2013-02-18 18:46 ` Al Viro
2013-02-18 19:46 ` Jeff Layton
2013-02-18 20:15 ` Al Viro [this message]
2013-02-18 23:14 ` NeilBrown
2013-02-19 12:33 ` Jeff Layton
2013-02-18 23:10 ` NeilBrown
2013-02-18 23:17 ` Myklebust, Trond
2013-02-18 23:31 ` NeilBrown
2013-02-19 14:27 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218201502.GH4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.