From: Dave Chinner <david@fromorbit.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 100: do not use scratch
Date: Tue, 19 Feb 2013 09:12:48 +1100 [thread overview]
Message-ID: <20130218221248.GC26694@dastard> (raw)
In-Reply-To: <1361173911-12422-1-git-send-email-lczerner@redhat.com>
On Mon, Feb 18, 2013 at 08:51:51AM +0100, Lukas Czerner wrote:
> Test #100 does not use scratch device at all but it still
> _require_scratch and _check_scratch_fs. This might also be a problem if
> the test before this one failed and corrupted scratch partition.
>
> Remove the _require_scratch() and _check_scratch_fs() from the test.
Actaully, I think it should be using scratch - have a look at where
TEMP_DIR is located. Yeah, it's /tmp, not the scratch device.
i.e. it should be using the TEST_DIR rather than tmp for building
the tarball, and scratch for restoring it....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-02-18 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 7:51 [PATCH] xfstests 100: do not use scratch Lukas Czerner
2013-02-18 22:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218221248.GC26694@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.