All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Chris Ball <cjb@laptop.org>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Will Newton <will.newton@imgtec.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412
Date: Mon, 18 Feb 2013 22:36:43 +0000	[thread overview]
Message-ID: <201302182236.43877.arnd@arndb.de> (raw)
In-Reply-To: <1361210793-5710-1-git-send-email-tobetter@gmail.com>

On Monday 18 February 2013, Dongjin Kim wrote:
> 
> This patch adds the compatible string for MSHC controller of Exynos4412, and
> share the controller specific properties with Exynos5250 since they have same
> features. Its driver data name is changed to exynos_drv_data instead SoC
> specific name.
> 
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Sachin Kamat <sachin.kamat@linaro.org>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>

If they are completely compatibly, you can just list
"samsung,exynos4412-dw-mshc" in the compatible property of the
exynos5250 device tree, along with the other ones like:

	compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc", "snps,dw-mshc";

then you don't need to change the driver at all.

	Arnd

  reply	other threads:[~2013-02-18 22:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 18:06 [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412 Dongjin Kim
2013-02-18 18:06 ` Dongjin Kim
2013-02-18 22:36 ` Arnd Bergmann [this message]
2013-02-19 10:19 ` Seungwon Jeon
2013-02-19 12:34   ` Dongjin Kim
2013-02-19 16:40     ` Alim Akhtar
2013-02-21 10:53       ` Seungwon Jeon
2013-02-22  1:39         ` Dongjin Kim
2013-02-22 11:16           ` Seungwon Jeon
2013-02-22 15:17 ` [PATCH v4] " Dongjin Kim
2013-02-22 15:17   ` Dongjin Kim
2013-03-13 14:17   ` Seungwon Jeon
2013-03-22 16:56     ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302182236.43877.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    --cc=thomas.abraham@linaro.org \
    --cc=tobetter@gmail.com \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.