From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Slusarz Subject: Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242 Date: Tue, 19 Feb 2013 00:23:35 +0100 Message-ID: <20130218232335.GA9730@joi.lan> References: <5122021F.1060207@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5122021F.1060207@suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Jiri Slaby Cc: bskeggs@redhat.com, dri-devel@lists.freedesktop.org, LKML List-Id: dri-devel@lists.freedesktop.org On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > Hi, > > we have a report of WARNING from 3.7.6 in nouveau at > drivers/gpu/drm/nouveau/core/core/mm.c:242 here: > https://bugzilla.novell.com/show_bug.cgi?id=802347#c11 > > There is an order 4 allocation failure in nouveau_drm_open -> > nouveau_vm_create, i.e. this one failed: > vm->pgt = kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL); > > Then, on the error path in still in nouveau_drm_open, it is followed by > a call to nouveau_cli_destroy. But that one calls nouveau_vm_ref -> > nouveau_mm_fini -> nouveau_vm_del -> nouveau_mm_fini which triggers the > warning. > > Any ideas? Crash/warning should be fixed by commit cfd376b6bfccf33782a0748a9c70f7f752f8b869 "drm/nouveau/vm: fix memory corruption when pgt allocation fails". Tomorrow I'll post a patch for page allocation failure. Marcin