From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: wm8994: add missing variable initialization
Date: Tue, 19 Feb 2013 12:18:01 +0000 [thread overview]
Message-ID: <20130219121801.GB23508@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <000001ce0e3b$f1d99170$d58cb450$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Tue, Feb 19, 2013 at 09:56:26AM +0900, Jingoo Han wrote:
> - int ret, i, patch_regs;
> + int ret, i, patch_regs = 0;
As with all such changes you really need to explain why it's safe to
just blindly initialise to this particular value and why this isn't just
masking a real issue in the code. Initialising with a random value will
fix the warning but that might just be turning off the compiler's
checks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-19 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 0:56 [PATCH] mfd: wm8994: add missing variable initialization Jingoo Han
2013-02-19 12:18 ` Mark Brown [this message]
2013-02-20 2:53 ` [PATCH v2] mfd: wm8994: silence bogus warning in wm8994_device_init() Jingoo Han
2013-02-20 16:48 ` Mark Brown
2013-04-08 9:57 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219121801.GB23508@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.