All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: question regarding 2.6.18 backport
Date: Tue, 19 Feb 2013 14:51:05 +0100	[thread overview]
Message-ID: <20130219145105.6274e9ea@hawk.usersys.redhat.com> (raw)

Hi Ian,

I believe there's a problem with the 2.6.18 reference tree backport of
48856286b64e: "xen/netback: shutdown the ring if it contains garbage",
which is c/s 1219. While the version in Linus' tree should be fine,
as xen_netbk_tx_action runs in a kthread, the 2.6.18 version needs
something different. In 2.6.18 net_tx_action is a tasklet, thus calling
xenvif_carrier_off from it is problematic due to needing the rtnl
mutex. A proposal I have that I haven't tried yet is for
netbk_fatal_tx_err to schedule xenvif_carrier_off in a workqueue. This
is a bit ugly though since the main point of xenvif_carrier_off is to
queue linkwatch work. I'm wondering if you or anyone else have other
suggestions.

Thanks,
Drew

             reply	other threads:[~2013-02-19 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 13:51 Andrew Jones [this message]
2013-02-19 13:54 ` question regarding 2.6.18 backport Ian Campbell
2013-02-19 14:39   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130219145105.6274e9ea@hawk.usersys.redhat.com \
    --to=drjones@redhat.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.